You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/03/31 21:06:13 UTC

[GitHub] [trafficcontrol] rob05c opened a new pull request #5696: Change lib/go-log to escape newlines

rob05c opened a new pull request #5696:
URL: https://github.com/apache/trafficcontrol/pull/5696


   Changes lib/go-log to escape newlines in the message. 
   
   This is intended to make log parsing easier. It's currently difficult or impossible for loggers to parse messages across multiple lines. Traffic Control logs should generally not be multiple lines, but this guarantees it for log parsers.
   
   Includes tests.
   No docs, the exact log format isn't documented.
   No changelog, no interface change.
   
   - [x] This PR is not related to any other Issue
   
   ## Which Traffic Control components are affected by this PR?
   This is a library. So theoretically everything. But nothing should be logging newlines anyway.
   
   ## What is the best way to verify this PR?
   Run unit tests.
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   Not a bug fix.
   
   ## The following criteria are ALL met by this PR
   - [x] This PR includes tests OR I have explained why tests are unnecessary
   - [x] This PR includes documentation OR I have explained why documentation is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   
   
   ## Additional Information
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org