You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lenya.apache.org by le...@cocoon.apache.org on 2004/11/01 03:20:50 UTC

[Cocoon Lenya Wiki] Updated: CodeContribution

   Date: 2004-10-31T18:20:50
   Editor: GregorRothfuss <gr...@apache.org>
   Wiki: Cocoon Lenya Wiki
   Page: CodeContribution
   URL: http://wiki.apache.org/cocoon-lenya/CodeContribution

   no comment

Change Log:

------------------------------------------------------------------------------
@@ -7,18 +7,16 @@
 
  1. Write and check your code, making sure you follow the [http://cocoon.apache.org/lenya/docs/misc/coding-guidelines.html coding guidelines].
 
-  * Test the new Webapp as generated by {{{ant install}}}
-  * Make sure the Lenya test classes still compile, by running {{{ant test}}}
+  * Test the new Webapp as generated by {{{build}}}
+  * Make sure the Lenya test classes still compile, by running {{{build test}}}
 
  1. Make sure you have added meaningful javadocs, at least to all classes and methods and to public fields.
 
- 1. The patch will consist of the differences between the code you have stored locally and the code in the CVS repository. There are 2 ways to generate such a patch: either using the CVS tools directory, or by using an IDE such as Eclipse.
-
-  * Preparing a patch using the CVS tools: see the Cocoon documentation [http://cocoon.apache.org/2.1/howto/howto-patch.html How to Prepare a Patch] 
+ 1. The patch will consist of the differences between the code you have stored locally and the code in the SVN repository. It is best to generate a patch with a IDE like Eclipse to make sure you catch all the files you need.
 
   * Preparing a patch using the Eclipse IDE:
-         * get the Lenya sources from cvs within Eclipse, see [http://GETLenya Get Lenya for Eclipse Users]
-         * ensure your environment is set to UTF-8 encoding. When you choose the project "cocoon-lenya" in Eclipse, and show the properties, see the field "Default encoding for text files". This ''must'' be set to "Inherit from container (UTF-8)". If not, you need to change your environment so that UTF-8 is the default encoding. It is not sufficient to override this in Eclipse, as Eclipse relies on the environment when creating a patch
+         * get the Lenya sources from svn within Eclipse, see [http://GETLenya Get Lenya for Eclipse Users]
+         * ensure your environment is set to UTF-8 encoding. When you choose the project "lenya" in Eclipse, and show the properties, see the field "Default encoding for text files". This ''must'' be set to "Inherit from container (UTF-8)". If not, you need to change your environment so that UTF-8 is the default encoding. It is not sufficient to override this in Eclipse, as Eclipse relies on the environment when creating a patch
          * edit your code within Eclipse
          * in the context-menu, choose "Team - Create Patch ...". Choose "Save in File System", "Next >". Make sure that "Recurse into sub-folders" is set. If have created any new files, make sure "Include new files in patch" is set. Choose "Unified" as diff format.
 
@@ -26,7 +24,7 @@
  1. Test your patch by applying it to a fresh checkout of Lenya. 
 
   * Testing a patch using Eclipse:
-   * retrieve a fresh version of Lenya from CVS into another Eclipse project (use a different name)
+   * retrieve a fresh version of Lenya from SVN into another Eclipse project (use a different name)
    * in the context-menu, choose "Team - Apply Patch ...". Choose your file and click on "Next >". Now verify that all desired files appear, and their checkboxes are checked, without warnings. If not, click on the file details and see what is wrong. You will need to recreate your patch, once you have eliminated the problems. 
 
 == Submitting a Patch ==

---------------------------------------------------------------------
To unsubscribe, e-mail: lenya-dev-unsubscribe@cocoon.apache.org
For additional commands, e-mail: lenya-dev-help@cocoon.apache.org