You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by Ben Becker <bb...@maprtech.com> on 2013/08/28 02:22:28 UTC

Review Request 13873: Implement left merge join

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13873/
-----------------------------------------------------------

Review request for drill and Jacques Nadeau.


Repository: drill-git


Description
-------

Implements left join via template and code generation.  The SV4 advance mode is largely untested (as is multi-batch) due to issues reading new schemas from the JSON source.

GitHub: https://github.com/vrtx/incubator-drill/commits/merge_join_cg


Diffs
-----

  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/compile/JaninoClassCompiler.java abe2afe 
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/expr/CodeGenerator.java d2e4cf3 
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractPhysicalVisitor.java 3cd0d7c 
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/GroupScan.java acafd6c 
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalVisitor.java 39fc105 
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/SubScan.java f75ba19 
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/MergeJoinPOP.java PRE-CREATION 
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ImplCreator.java e69aeae 
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinEvaluator.java PRE-CREATION 
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinInnerSignature.java PRE-CREATION 
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinStatus.java PRE-CREATION 
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinTemplate.java PRE-CREATION 
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinWorker.java PRE-CREATION 
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java PRE-CREATION 
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatchBuilder.java PRE-CREATION 
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinCreator.java PRE-CREATION 
  sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/sort/RecordBatchData.java a21af09 
  sandbox/prototype/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestMergeJoin.java PRE-CREATION 
  sandbox/prototype/exec/java-exec/src/test/resources/join/merge_join.json PRE-CREATION 
  sandbox/prototype/exec/java-exec/src/test/resources/join/merge_multi_batch.json PRE-CREATION 
  sandbox/prototype/exec/java-exec/src/test/resources/join/merge_multi_batch.left.json PRE-CREATION 
  sandbox/prototype/exec/java-exec/src/test/resources/join/merge_multi_batch.right.json PRE-CREATION 
  sandbox/prototype/exec/java-exec/src/test/resources/join/merge_single_batch.json PRE-CREATION 
  sandbox/prototype/exec/java-exec/src/test/resources/join/merge_single_batch.left.json PRE-CREATION 
  sandbox/prototype/exec/java-exec/src/test/resources/join/merge_single_batch.right.json PRE-CREATION 

Diff: https://reviews.apache.org/r/13873/diff/


Testing
-------


Thanks,

Ben Becker

Re: Review Request 13873: Implement left merge join

Posted by Jacques Nadeau <ja...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13873/#review26256
-----------------------------------------------------------

Ship it!


Ship It!

- Jacques Nadeau


On Aug. 28, 2013, 12:22 a.m., Ben Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13873/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2013, 12:22 a.m.)
> 
> 
> Review request for drill and Jacques Nadeau.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Implements left join via template and code generation.  The SV4 advance mode is largely untested (as is multi-batch) due to issues reading new schemas from the JSON source.
> 
> GitHub: https://github.com/vrtx/incubator-drill/commits/merge_join_cg
> 
> 
> Diffs
> -----
> 
>   sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/compile/JaninoClassCompiler.java abe2afe 
>   sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/expr/CodeGenerator.java d2e4cf3 
>   sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractPhysicalVisitor.java 3cd0d7c 
>   sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/GroupScan.java acafd6c 
>   sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalVisitor.java 39fc105 
>   sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/SubScan.java f75ba19 
>   sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/MergeJoinPOP.java PRE-CREATION 
>   sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ImplCreator.java e69aeae 
>   sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinEvaluator.java PRE-CREATION 
>   sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinInnerSignature.java PRE-CREATION 
>   sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinStatus.java PRE-CREATION 
>   sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinTemplate.java PRE-CREATION 
>   sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinWorker.java PRE-CREATION 
>   sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java PRE-CREATION 
>   sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatchBuilder.java PRE-CREATION 
>   sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinCreator.java PRE-CREATION 
>   sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/sort/RecordBatchData.java a21af09 
>   sandbox/prototype/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestMergeJoin.java PRE-CREATION 
>   sandbox/prototype/exec/java-exec/src/test/resources/join/merge_join.json PRE-CREATION 
>   sandbox/prototype/exec/java-exec/src/test/resources/join/merge_multi_batch.json PRE-CREATION 
>   sandbox/prototype/exec/java-exec/src/test/resources/join/merge_multi_batch.left.json PRE-CREATION 
>   sandbox/prototype/exec/java-exec/src/test/resources/join/merge_multi_batch.right.json PRE-CREATION 
>   sandbox/prototype/exec/java-exec/src/test/resources/join/merge_single_batch.json PRE-CREATION 
>   sandbox/prototype/exec/java-exec/src/test/resources/join/merge_single_batch.left.json PRE-CREATION 
>   sandbox/prototype/exec/java-exec/src/test/resources/join/merge_single_batch.right.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/13873/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ben Becker
> 
>

Re: Review Request 13873: Implement left merge join

Posted by Timothy Chen <tn...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13873/#review25648
-----------------------------------------------------------



sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/compile/JaninoClassCompiler.java
<https://reviews.apache.org/r/13873/#comment50140>

    Use StringBuilder?


- Timothy Chen


On Aug. 28, 2013, 12:22 a.m., Ben Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13873/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2013, 12:22 a.m.)
> 
> 
> Review request for drill and Jacques Nadeau.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Implements left join via template and code generation.  The SV4 advance mode is largely untested (as is multi-batch) due to issues reading new schemas from the JSON source.
> 
> GitHub: https://github.com/vrtx/incubator-drill/commits/merge_join_cg
> 
> 
> Diffs
> -----
> 
>   sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/compile/JaninoClassCompiler.java abe2afe 
>   sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/expr/CodeGenerator.java d2e4cf3 
>   sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractPhysicalVisitor.java 3cd0d7c 
>   sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/GroupScan.java acafd6c 
>   sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalVisitor.java 39fc105 
>   sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/SubScan.java f75ba19 
>   sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/MergeJoinPOP.java PRE-CREATION 
>   sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ImplCreator.java e69aeae 
>   sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinEvaluator.java PRE-CREATION 
>   sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinInnerSignature.java PRE-CREATION 
>   sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinStatus.java PRE-CREATION 
>   sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinTemplate.java PRE-CREATION 
>   sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/JoinWorker.java PRE-CREATION 
>   sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java PRE-CREATION 
>   sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatchBuilder.java PRE-CREATION 
>   sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinCreator.java PRE-CREATION 
>   sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/sort/RecordBatchData.java a21af09 
>   sandbox/prototype/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestMergeJoin.java PRE-CREATION 
>   sandbox/prototype/exec/java-exec/src/test/resources/join/merge_join.json PRE-CREATION 
>   sandbox/prototype/exec/java-exec/src/test/resources/join/merge_multi_batch.json PRE-CREATION 
>   sandbox/prototype/exec/java-exec/src/test/resources/join/merge_multi_batch.left.json PRE-CREATION 
>   sandbox/prototype/exec/java-exec/src/test/resources/join/merge_multi_batch.right.json PRE-CREATION 
>   sandbox/prototype/exec/java-exec/src/test/resources/join/merge_single_batch.json PRE-CREATION 
>   sandbox/prototype/exec/java-exec/src/test/resources/join/merge_single_batch.left.json PRE-CREATION 
>   sandbox/prototype/exec/java-exec/src/test/resources/join/merge_single_batch.right.json PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/13873/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ben Becker
> 
>