You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/09/15 02:18:40 UTC
[GitHub] [calcite] xy2953396112 opened a new pull request #2519: [CALCITE-3583] Support serialized to json and deserialized from json …
xy2953396112 opened a new pull request #2519:
URL: https://github.com/apache/calcite/pull/2519
…for Exchange relation operator. (Xzh & Wang YanLin)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] yanlin-Lynn commented on pull request #2519: [CALCITE-4778] Exchange operator deserialize fail when the RexInput has no RelCollcation
Posted by GitBox <gi...@apache.org>.
yanlin-Lynn commented on pull request #2519:
URL: https://github.com/apache/calcite/pull/2519#issuecomment-928653359
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] xy2953396112 commented on a change in pull request #2519: [CALCITE-3583] Support serialized to json and deserialized from json …
Posted by GitBox <gi...@apache.org>.
xy2953396112 commented on a change in pull request #2519:
URL: https://github.com/apache/calcite/pull/2519#discussion_r712602107
##########
File path: core/src/main/java/org/apache/calcite/rel/RelDistributions.java
##########
@@ -88,6 +88,15 @@ private static ImmutableIntList normalizeKeys(Collection<? extends Number> keys)
return list;
}
+ /** Creates a distribution. */
+ public static RelDistribution distribution(
Review comment:
Not necessary,There is already a [PR](https://issues.apache.org/jira/browse/CALCITE-3867) that supports serialization and deserialization.but when I tested the unit test `testExchange`, I got the message below.
java.lang.NullPointerException: no entry for tag collation
java.lang.RuntimeException: java.lang.NullPointerException: no entry for tag collation
at org.apache.calcite.tools.Frameworks.withPrepare(Frameworks.java:193)
at org.apache.calcite.tools.Frameworks.withPlanner(Frameworks.java:135)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] yanlin-Lynn commented on pull request #2519: [CALCITE-4778] Exchange operator deserialize fail
Posted by GitBox <gi...@apache.org>.
yanlin-Lynn commented on pull request #2519:
URL: https://github.com/apache/calcite/pull/2519#issuecomment-927679374
Remove the "." in the commit log please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] yanlin-Lynn merged pull request #2519: [CALCITE-4778] Exchange operator deserialize fail when the RexInput has no RelCollcation
Posted by GitBox <gi...@apache.org>.
yanlin-Lynn merged pull request #2519:
URL: https://github.com/apache/calcite/pull/2519
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] xy2953396112 commented on pull request #2519: [CALCITE-3583] Support serialized to json and deserialized from json …
Posted by GitBox <gi...@apache.org>.
xy2953396112 commented on pull request #2519:
URL: https://github.com/apache/calcite/pull/2519#issuecomment-920720142
@Julianhyde @yanlin-Lynn @zabetak @hsyuan
Please help review this pr when you have time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] xy2953396112 commented on a change in pull request #2519: [CALCITE-3583] Support serialized to json and deserialized from json …
Posted by GitBox <gi...@apache.org>.
xy2953396112 commented on a change in pull request #2519:
URL: https://github.com/apache/calcite/pull/2519#discussion_r712603329
##########
File path: core/src/main/java/org/apache/calcite/rel/RelDistributions.java
##########
@@ -88,6 +88,15 @@ private static ImmutableIntList normalizeKeys(Collection<? extends Number> keys)
return list;
}
+ /** Creates a distribution. */
+ public static RelDistribution distribution(
Review comment:
Should I make a new JIRA?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] hsyuan commented on a change in pull request #2519: [CALCITE-3583] Support serialized to json and deserialized from json …
Posted by GitBox <gi...@apache.org>.
hsyuan commented on a change in pull request #2519:
URL: https://github.com/apache/calcite/pull/2519#discussion_r712498034
##########
File path: core/src/main/java/org/apache/calcite/rel/RelDistributions.java
##########
@@ -88,6 +88,15 @@ private static ImmutableIntList normalizeKeys(Collection<? extends Number> keys)
return list;
}
+ /** Creates a distribution. */
+ public static RelDistribution distribution(
Review comment:
Why is this needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] yanlin-Lynn commented on pull request #2519: [CALCITE-4778] Exchange operator deserialize fail when the RexInput has no RelCollcation
Posted by GitBox <gi...@apache.org>.
yanlin-Lynn commented on pull request #2519:
URL: https://github.com/apache/calcite/pull/2519#issuecomment-928653359
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] xy2953396112 commented on a change in pull request #2519: [CALCITE-4778] Exchange operator deserialize fail
Posted by GitBox <gi...@apache.org>.
xy2953396112 commented on a change in pull request #2519:
URL: https://github.com/apache/calcite/pull/2519#discussion_r712603329
##########
File path: core/src/main/java/org/apache/calcite/rel/RelDistributions.java
##########
@@ -88,6 +88,15 @@ private static ImmutableIntList normalizeKeys(Collection<? extends Number> keys)
return list;
}
+ /** Creates a distribution. */
+ public static RelDistribution distribution(
Review comment:
Should I make a new JIRA?
https://issues.apache.org/jira/browse/CALCITE-4778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] xy2953396112 commented on pull request #2519: [CALCITE-4778] Exchange operator deserialize fail
Posted by GitBox <gi...@apache.org>.
xy2953396112 commented on pull request #2519:
URL: https://github.com/apache/calcite/pull/2519#issuecomment-925487197
@yanlin-Lynn
Please help review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org