You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by bu...@apache.org on 2009/07/28 15:45:07 UTC

DO NOT REPLY [Bug 47595] New: [companion] POMs of companions have problems

https://issues.apache.org/bugzilla/show_bug.cgi?id=47595

           Summary: [companion] POMs of companions have problems
           Product: Log4j
           Version: unspecified
          Platform: PC
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Other
        AssignedTo: log4j-dev@logging.apache.org
        ReportedBy: antonio.petrelli@gmail.com


The POM files of the companions project have problems:
* they state they are using 1.2 as the compile version, but they are using
classes from 1.4+ (e.g. XML DOM classes);
* the "assembly" goal is not connected to a phase (I suppose that it is
"package"
* project "apache-log4j-receivers" depend on log4j 1.2.16-SNAPSHOT, while
version 1.2.15 is enough.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


DO NOT REPLY [Bug 47595] [companion] POMs of companions have problems

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47595

--- Comment #7 from Curt Arnold <ca...@apache.org> 2009-10-04 06:17:10 PDT ---
Good to know the problem you were trying to fix.  Is this observed with Eclipse
projects that are generated with "mvn eclipse:eclipse", with projects that
Eclipse reads directly or is it using Maven with the Eclipse java compiler?

Leaving the byte-code at 1.1 allows us to binary diff the generated classes
with earlier versions of log4j 1.2 to determine that we didn't make inadvertent
changes between versions.  That is an auditing step that we could still do by
rolling back the target, but it is an extra annoyance and it is a nice check
for something as widely deployed as log4j.

The assert keyword was added in the Java language at 1.4.  I'm not sure if that
required upgrading the byte-code version to 1.4 also.  Could you try just
upgrading the source to 1.4 and see if that eliminates your issue with Eclipse.
 Updating source to 1.5 definitely requires updating the byte-code to 1.5 since
there are productions that can not be generated using 1.1 byte code.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


DO NOT REPLY [Bug 47595] [companion] POMs of companions have problems

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47595





--- Comment #1 from Antonio Petrelli <an...@gmail.com>  2009-07-28 06:48:35 PST ---
Created an attachment (id=24050)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24050)
Patch for the "apache-log4j-component" project

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


[Bug 47595] [companion] POMs of companions have problems

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47595

grobmeier <gr...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #9 from grobmeier <gr...@gmail.com> ---
We are using the Apache parent pom meanwhile and have merged the components to
a single jar. Therefore I am closing this issue as described problems should
not longer occur. Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


DO NOT REPLY [Bug 47595] [companion] POMs of companions have problems

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47595





--- Comment #3 from Antonio Petrelli <an...@gmail.com>  2009-07-28 06:49:38 PST ---
Created an attachment (id=24052)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24052)
Patch for the "apache-log4j-receivers" project

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


DO NOT REPLY [Bug 47595] [companion] POMs of companions have problems

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47595





--- Comment #2 from Antonio Petrelli <an...@gmail.com>  2009-07-28 06:49:11 PST ---
Created an attachment (id=24051)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=24051)
Patch for the "apache-log4j-extras" project

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


DO NOT REPLY [Bug 47595] [companion] POMs of companions have problems

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47595

Scott Deboy <sd...@iname.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Scott Deboy <sd...@iname.com> 2009-10-03 14:13:43 PDT ---
Fix committed to svn trunk in r821364

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


[Bug 47595] [companion] POMs of companions have problems

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47595

grobmeier <gr...@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |log4j-dev@logging.apache.or
                   |                            |g
          Component|Other                       |Companions

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


DO NOT REPLY [Bug 47595] [companion] POMs of companions have problems

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47595

--- Comment #8 from Antonio Petrelli <an...@gmail.com> 2009-10-05 01:24:19 PDT ---
I use m2eclipse plugin, so it's a Maven inside Eclipse.
It's a strange situation, now everything works fine, with the exception of an
error in the properties of the project, as Eclipse (Galileo)  does not list 1.2
version as possible value of the Java source :-O
Anyway, it compiles.
So, I think the source/target levels can be restored to original values.

About the asserts, what are you referring to? I don't see any assert inside the
companion code.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


DO NOT REPLY [Bug 47595] [companion] POMs of companions have problems

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47595

Curt Arnold <ca...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |

--- Comment #5 from Curt Arnold <ca...@apache.org> 2009-10-03 21:13:11 PDT ---
Sorry, I thought I had commented on this on the mailing list.

javax.xml.parsers was available for earlier JDK's as an additional component.

The source and target parameters on a Java compiler do not indicate the version
of JDK necessary to build the component, they specify the version of the Java
language specification accepted and the version of the Java byte-code emitted. 
There are specific reasons why 1.1 was chose for byte-code and 1.2 was selected
for source.  Those choices were made a long time ago and maybe the should be
review but the post did indicate any specific problem that occurred due to that
choice or advantage that would be gained by changing the versions.  As deep in
the maintenance cycle as log4j 1.2 is, it seems unwise to make changes for no
defined benefit.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org


DO NOT REPLY [Bug 47595] [companion] POMs of companions have problems

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=47595

--- Comment #6 from Antonio Petrelli <an...@gmail.com> 2009-10-04 04:16:09 PDT ---
I must admit that the compilation problem appears only in Eclipse, because,
when choosing a runtime environment, it enforces restrictions in class use. In
this case, if I have a 1.2 version of JDK, I cannot use XML classes.
Usually this is not an issue, but probably, since Eclipse is OSGi based, this
can cause a problem under OSGi-based applications (never tested it, though).
Anyway I don't see why it is a problem to "upgrade" the companions, Java 1.2 is
abandoned, Java 5 is at the end-of-life, Java 1.4 seems "reasonably old" :-D

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org