[GitHub] [kafka] jsancio commented on a diff in pull request #12994: KAFKA-14457; Controller metrics should only expose committed data

[GitBox <gi...@apache.org>]

jsancio commented on code in PR #12994:
URL: https://github.com/apache/kafka/pull/12994#discussion_r1052646518


##########
metadata/src/main/java/org/apache/kafka/controller/PartitionChangeBuilder.java:
##########
@@ -17,6 +17,11 @@
 
 package org.apache.kafka.controller;
 
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+import java.util.Optional;
+import java.util.function.IntPredicate;

Review Comment:
   I think that is beyond the scope of this PR. We should do that in a follow up minor PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org