You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/21 20:26:48 UTC
[GitHub] [airflow] eladkal opened a new pull request #20454: organize Opsgenie provider classes
eladkal opened a new pull request #20454:
URL: https://github.com/apache/airflow/pull/20454
Organize Opsgenie classes.
Since https://github.com/apache/airflow/pull/20263 is a breaking change I want to take the opportunity to organize the classes along with it.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a change in pull request #20454: Organize Opsgenie provider classes
Posted by GitBox <gi...@apache.org>.
eladkal commented on a change in pull request #20454:
URL: https://github.com/apache/airflow/pull/20454#discussion_r773437257
##########
File path: airflow/providers/opsgenie/CHANGELOG.rst
##########
@@ -29,6 +29,16 @@ Removed the ``OpsegnieAlertHook.execute`` method and replaced it with ``Opsegnie
``OpsgenieAlertHook`` now takes ``visible_to`` instead of ``visibleTo`` key in the payload.
``OpsgenieAlertHook`` now takes ``request_id`` instead of ``requestId`` key in the payload.
+Changes were made to classes paths:
+
++-----------------------+-----------------------------------------------------+-----------------------------------------------+
+| Class | Old Path | New Path |
++-----------------------+-----------------------------------------------------+-----------------------------------------------+
+| OpsgenieAlertHook | airflow.providers.opsgenie.hooks.opsgenie_alert | airflow.providers.opsgenie.hooks.opsgenie |
++-----------------------+-----------------------------------------------------+-----------------------------------------------+
+| OpsgenieAlertOperator | airflow.providers.opsgenie.operators.opsgenie_alert | airflow.providers.opsgenie.operators.opsgenie |
++-----------------------+-----------------------------------------------------+-----------------------------------------------+
Review comment:
I made the paths backward compatible so no need for the table at the end :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #20454: Organize Opsgenie provider classes
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #20454:
URL: https://github.com/apache/airflow/pull/20454#issuecomment-999321943
Should be OK now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #20454: organize Opsgenie provider classes
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #20454:
URL: https://github.com/apache/airflow/pull/20454#issuecomment-999072779
Ahh wait. Not ready yet. mark as draft.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal edited a comment on pull request #20454: organize Opsgenie provider classes
Posted by GitBox <gi...@apache.org>.
eladkal edited a comment on pull request #20454:
URL: https://github.com/apache/airflow/pull/20454#issuecomment-999072779
Ahh. Not ready yet. mark as draft.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #20454: Organize Opsgenie provider classes
Posted by GitBox <gi...@apache.org>.
eladkal commented on pull request #20454:
URL: https://github.com/apache/airflow/pull/20454#issuecomment-999411781
transient errors of helm tests. Not related to this change.
merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #20454: organize Opsgenie provider classes
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #20454:
URL: https://github.com/apache/airflow/pull/20454#discussion_r773430065
##########
File path: airflow/providers/opsgenie/CHANGELOG.rst
##########
@@ -29,6 +29,16 @@ Removed the ``OpsegnieAlertHook.execute`` method and replaced it with ``Opsegnie
``OpsgenieAlertHook`` now takes ``visible_to`` instead of ``visibleTo`` key in the payload.
``OpsgenieAlertHook`` now takes ``request_id`` instead of ``requestId`` key in the payload.
+Changes were made to classes paths:
+
++-----------------------+-----------------------------------------------------+-----------------------------------------------+
+| Class | Old Path | New Path |
++-----------------------+-----------------------------------------------------+-----------------------------------------------+
+| OpsgenieAlertHook | airflow.providers.opsgenie.hooks.opsgenie_alert | airflow.providers.opsgenie.hooks.opsgenie |
++-----------------------+-----------------------------------------------------+-----------------------------------------------+
+| OpsgenieAlertOperator | airflow.providers.opsgenie.operators.opsgenie_alert | airflow.providers.opsgenie.operators.opsgenie |
++-----------------------+-----------------------------------------------------+-----------------------------------------------+
Review comment:
```suggestion
+---------------------------+---------------------------------------------------------+---------------------------------------------------+
| Class | Old Path | New Path |
+---------------------------+---------------------------------------------------------+---------------------------------------------------+
| ``OpsgenieAlertHook`` | ``airflow.providers.opsgenie.hooks.opsgenie_alert`` | ``airflow.providers.opsgenie.hooks.opsgenie`` |
+---------------------------+-------------------------------------------------------------+-----------------------------------------------+
| ``OpsgenieAlertOperator`` | ``airflow.providers.opsgenie.operators.opsgenie_alert`` | ``airflow.providers.opsgenie.operators.opsgenie`` |
+---------------------------+---------------------------------------------------------+---------------------------------------------------+
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #20454: Organize Opsgenie provider classes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #20454:
URL: https://github.com/apache/airflow/pull/20454#issuecomment-999079863
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal merged pull request #20454: Organize Opsgenie provider classes
Posted by GitBox <gi...@apache.org>.
eladkal merged pull request #20454:
URL: https://github.com/apache/airflow/pull/20454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org