You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "He-Pin (via GitHub)" <gi...@apache.org> on 2023/06/10 12:51:14 UTC

[GitHub] [incubator-pekko-connectors] He-Pin commented on a diff in pull request #159: support scala3 for google-cloud-storage connector

He-Pin commented on code in PR #159:
URL: https://github.com/apache/incubator-pekko-connectors/pull/159#discussion_r1225343645


##########
google-cloud-storage/src/main/scala/org/apache/pekko/stream/connectors/googlecloud/storage/impl/Formats.scala:
##########
@@ -110,8 +110,8 @@ object Formats extends DefaultJsonProtocol {
       StorageObjectJson(readOnlyFields, writeableFields)
     }
     override def write(obj: StorageObjectJson): JsValue = {
-      val fields1 = obj.readable.toJson.asJsObject.fields
-      val fields2 = obj.writeable.toJson.asJsObject.fields
+      val fields1 = spray.json.enrichAny(obj.readable).toJson.asJsObject.fields
+      val fields2 = spray.json.enrichAny(obj.writeable).toJson.asJsObject.fields

Review Comment:
   What's the error here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org