You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/06 19:15:13 UTC

[GitHub] [incubator-superset] mistercrunch opened a new pull request #11174: chore: add issue template for 'Cosmetic Issue'

mistercrunch opened a new pull request #11174:
URL: https://github.com/apache/incubator-superset/pull/11174


   title ^


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] rusackas commented on a change in pull request #11174: chore: add issue template for 'Cosmetic Issue'

Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #11174:
URL: https://github.com/apache/incubator-superset/pull/11174#discussion_r500542947



##########
File path: .github/ISSUE_TEMPLATE/cosmetic.md
##########
@@ -0,0 +1,14 @@
+---
+name: Cosmetic Issue
+about: Describe a cosmetic issue with CSS, positioning, layout, labeling, or something of that nature
+labels: "cosmetic-issue", "good first issue"
+
+---
+
+## Screenshot
+
+[drag & drop image(s) here!]
+
+## Description
+
+[describe the issue here!]

Review comment:
       ```suggestion
   [describe the issue here!]
   
   ## Design input
   
   [describe any input/collaboration you'd like from designers, and tag accordingly. For design review, add the label `design:review`. If this includes a design proposal, include the label `design:suggest`]
   
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io commented on pull request #11174: chore: add issue template for 'Cosmetic Issue'

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11174:
URL: https://github.com/apache/incubator-superset/pull/11174#issuecomment-704504433


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=h1) Report
   > Merging [#11174](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13963acefb26f7f174d3cb1c4f503027b4c12ba0?el=desc) will **increase** coverage by `0.60%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11174/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11174      +/-   ##
   ==========================================
   + Coverage   61.69%   62.30%   +0.60%     
   ==========================================
     Files         828      437     -391     
     Lines       39116    14631   -24485     
     Branches     3688     3688              
   ==========================================
   - Hits        24134     9116   -15018     
   + Misses      14801     5334    -9467     
     Partials      181      181              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `62.30% <ø> (-37.70%)` | :arrow_down: |
   | #python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/theme.ts](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3RoZW1lLnRz) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/CRUD/utils.js](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvdXRpbHMuanM=) | `100.00% <0.00%> (ø)` | |
   | [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `62.02% <0.00%> (ø)` | |
   | [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/CRUD/Field.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvRmllbGQuanN4) | `83.33% <0.00%> (ø)` | |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/views/menu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL21lbnUudHN4) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `10.90% <0.00%> (ø)` | |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (ø)` | |
   | ... and [818 more](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=footer). Last update [13963ac...52e6d0e](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11174: chore: add issue template for 'Cosmetic Issue'

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11174:
URL: https://github.com/apache/incubator-superset/pull/11174#issuecomment-704504433


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=h1) Report
   > Merging [#11174](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13963acefb26f7f174d3cb1c4f503027b4c12ba0?el=desc) will **decrease** coverage by `6.48%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11174/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11174      +/-   ##
   ==========================================
   - Coverage   61.69%   55.21%   -6.49%     
   ==========================================
     Files         828      403     -425     
     Lines       39116    13373   -25743     
     Branches     3688     3426     -262     
   ==========================================
   - Hits        24134     7384   -16750     
   + Misses      14801     5797    -9004     
   - Partials      181      192      +11     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `55.21% <ø> (?)` | |
   | #javascript | `?` | |
   | #python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rc/dashboard/util/getLayoutComponentFromChartId.js](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldExheW91dENvbXBvbmVudEZyb21DaGFydElkLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
   | [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
   | [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
   | [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
   | [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
   | [superset-frontend/src/common/components/Modal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL01vZGFsLnRzeA==) | `6.66% <0.00%> (-93.34%)` | :arrow_down: |
   | ... and [818 more](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=footer). Last update [13963ac...6398946](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11174: chore: add issue template for 'Cosmetic Issue'

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11174:
URL: https://github.com/apache/incubator-superset/pull/11174#issuecomment-704504433


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=h1) Report
   > Merging [#11174](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13963acefb26f7f174d3cb1c4f503027b4c12ba0?el=desc) will **increase** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11174/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #11174   +/-   ##
   =======================================
     Coverage   61.69%   61.70%           
   =======================================
     Files         828      828           
     Lines       39116    39116           
     Branches     3688     3688           
   =======================================
   + Hits        24134    24137    +3     
   + Misses      14801    14798    -3     
     Partials      181      181           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `62.30% <ø> (-37.70%)` | :arrow_down: |
   | #python | `61.34% <ø> (+0.86%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `67.26% <0.00%> (ø)` | |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <0.00%> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/theme.ts](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3RoZW1lLnRz) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/CRUD/utils.js](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvdXRpbHMuanM=) | `100.00% <0.00%> (ø)` | |
   | [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `62.02% <0.00%> (ø)` | |
   | [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/CRUD/Field.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvRmllbGQuanN4) | `83.33% <0.00%> (ø)` | |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (ø)` | |
   | ... and [452 more](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=footer). Last update [13963ac...52e6d0e](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch merged pull request #11174: chore: add issue template for 'Cosmetic Issue'

Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #11174:
URL: https://github.com/apache/incubator-superset/pull/11174


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11174: chore: add issue template for 'Cosmetic Issue'

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11174:
URL: https://github.com/apache/incubator-superset/pull/11174#issuecomment-704504433


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=h1) Report
   > Merging [#11174](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13963acefb26f7f174d3cb1c4f503027b4c12ba0?el=desc) will **decrease** coverage by `0.65%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11174/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11174      +/-   ##
   ==========================================
   - Coverage   61.69%   61.04%   -0.66%     
   ==========================================
     Files         828      828              
     Lines       39116    39105      -11     
     Branches     3688     3688              
   ==========================================
   - Hits        24134    23870     -264     
   - Misses      14801    15054     +253     
     Partials      181      181              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `62.30% <ø> (-37.70%)` | :arrow_down: |
   | #python | `60.28% <ø> (-0.20%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `31.91% <0.00%> (-59.58%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-22.81%)` | :arrow_down: |
   | [superset/databases/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `94.11% <0.00%> (-5.89%)` | :arrow_down: |
   | [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | `78.94% <0.00%> (-5.27%)` | :arrow_down: |
   | [superset/databases/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | `94.77% <0.00%> (-5.23%)` | :arrow_down: |
   | [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `81.38% <0.00%> (-7.98%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-11.67%)` | :arrow_down: |
   | [superset/datasets/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvY3JlYXRlLnB5) | `98.14% <0.00%> (-1.86%)` | :arrow_down: |
   | ... and [449 more](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=footer). Last update [13963ac...52e6d0e](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11174: chore: add issue template for 'Cosmetic Issue'

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11174:
URL: https://github.com/apache/incubator-superset/pull/11174#issuecomment-704504433


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=h1) Report
   > Merging [#11174](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13963acefb26f7f174d3cb1c4f503027b4c12ba0?el=desc) will **decrease** coverage by `5.82%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11174/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11174      +/-   ##
   ==========================================
   - Coverage   61.69%   55.87%   -5.83%     
   ==========================================
     Files         828      403     -425     
     Lines       39116    13373   -25743     
     Branches     3688     3426     -262     
   ==========================================
   - Hits        24134     7472   -16662     
   + Misses      14801     5717    -9084     
   - Partials      181      184       +3     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `55.87% <ø> (?)` | |
   | #javascript | `?` | |
   | #python | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...rc/dashboard/util/getLayoutComponentFromChartId.js](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldExheW91dENvbXBvbmVudEZyb21DaGFydElkLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [.../src/dashboard/util/getFilterScopeFromNodesTree.js](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEZpbHRlclNjb3BlRnJvbU5vZGVzVHJlZS5qcw==) | `0.00% <0.00%> (-93.48%)` | :arrow_down: |
   | [.../src/dashboard/components/FilterIndicatorGroup.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0ZpbHRlckluZGljYXRvckdyb3VwLmpzeA==) | `11.76% <0.00%> (-88.24%)` | :arrow_down: |
   | [...c/explore/components/controls/withVerification.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy93aXRoVmVyaWZpY2F0aW9uLmpzeA==) | `9.09% <0.00%> (-87.88%)` | :arrow_down: |
   | [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `10.52% <0.00%> (-86.85%)` | :arrow_down: |
   | [...rc/dashboard/components/gridComponents/Divider.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0RpdmlkZXIuanN4) | `13.33% <0.00%> (-86.67%)` | :arrow_down: |
   | [superset-frontend/src/common/components/Modal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL01vZGFsLnRzeA==) | `6.66% <0.00%> (-93.34%)` | :arrow_down: |
   | ... and [818 more](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=footer). Last update [13963ac...6398946](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11174: chore: add issue template for 'Cosmetic Issue'

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11174:
URL: https://github.com/apache/incubator-superset/pull/11174#issuecomment-704504433


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=h1) Report
   > Merging [#11174](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13963acefb26f7f174d3cb1c4f503027b4c12ba0?el=desc) will **increase** coverage by `4.20%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11174/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11174      +/-   ##
   ==========================================
   + Coverage   61.69%   65.90%   +4.20%     
   ==========================================
     Files         828      828              
     Lines       39116    39119       +3     
     Branches     3688     3688              
   ==========================================
   + Hits        24134    25782    +1648     
   + Misses      14801    13230    -1571     
   + Partials      181      107      -74     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `55.86% <ø> (?)` | |
   | #javascript | `62.30% <ø> (-37.70%)` | :arrow_down: |
   | #python | `61.34% <ø> (+0.86%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [...et-frontend/src/SqlLab/components/LimitControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0xpbWl0Q29udHJvbC50c3g=) | `84.78% <0.00%> (-1.89%)` | :arrow_down: |
   | [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `73.21% <0.00%> (-1.34%)` | :arrow_down: |
   | [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `67.26% <0.00%> (ø)` | |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <0.00%> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/theme.ts](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3RoZW1lLnRz) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/CRUD/utils.js](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvdXRpbHMuanM=) | `100.00% <0.00%> (ø)` | |
   | [superset-frontend/src/CRUD/Field.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvRmllbGQuanN4) | `83.33% <0.00%> (ø)` | |
   | [superset-frontend/src/profile/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Byb2ZpbGUvQXBwLnRzeA==) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/addSlice/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FwcC50c3g=) | `0.00% <0.00%> (ø)` | |
   | ... and [452 more](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=footer). Last update [13963ac...52e6d0e](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11174: chore: add issue template for 'Cosmetic Issue'

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11174:
URL: https://github.com/apache/incubator-superset/pull/11174#issuecomment-704504433


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=h1) Report
   > Merging [#11174](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13963acefb26f7f174d3cb1c4f503027b4c12ba0?el=desc) will **decrease** coverage by `0.10%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11174/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11174      +/-   ##
   ==========================================
   - Coverage   61.69%   61.59%   -0.11%     
   ==========================================
     Files         828      828              
     Lines       39116    39116              
     Branches     3688     3688              
   ==========================================
   - Hits        24134    24092      -42     
   - Misses      14801    14843      +42     
     Partials      181      181              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `62.30% <ø> (-37.70%)` | :arrow_down: |
   | #python | `61.16% <ø> (+0.68%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `67.26% <0.00%> (ø)` | |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <0.00%> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/theme.ts](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3RoZW1lLnRz) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/CRUD/utils.js](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvdXRpbHMuanM=) | `100.00% <0.00%> (ø)` | |
   | [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `62.02% <0.00%> (ø)` | |
   | [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/CRUD/Field.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvRmllbGQuanN4) | `83.33% <0.00%> (ø)` | |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (ø)` | |
   | ... and [449 more](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=footer). Last update [13963ac...52e6d0e](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11174: chore: add issue template for 'Cosmetic Issue'

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11174:
URL: https://github.com/apache/incubator-superset/pull/11174#issuecomment-704504433


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=h1) Report
   > Merging [#11174](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/13963acefb26f7f174d3cb1c4f503027b4c12ba0?el=desc) will **increase** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11174/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master   #11174   +/-   ##
   =======================================
     Coverage   61.69%   61.70%           
   =======================================
     Files         828      828           
     Lines       39116    39116           
     Branches     3688     3688           
   =======================================
   + Hits        24134    24137    +3     
   + Misses      14801    14798    -3     
     Partials      181      181           
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #javascript | `62.30% <ø> (-37.70%)` | :arrow_down: |
   | #python | `61.34% <ø> (+0.86%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `67.26% <0.00%> (ø)` | |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | `100.00% <0.00%> (ø)` | |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/theme.ts](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3RoZW1lLnRz) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/preamble.ts](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ByZWFtYmxlLnRz) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/CRUD/utils.js](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvdXRpbHMuanM=) | `100.00% <0.00%> (ø)` | |
   | [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `62.02% <0.00%> (ø)` | |
   | [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=) | `0.00% <0.00%> (ø)` | |
   | [superset-frontend/src/CRUD/Field.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0NSVUQvRmllbGQuanN4) | `83.33% <0.00%> (ø)` | |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (ø)` | |
   | ... and [452 more](https://codecov.io/gh/apache/incubator-superset/pull/11174/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=footer). Last update [13963ac...52e6d0e](https://codecov.io/gh/apache/incubator-superset/pull/11174?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org