You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2011/06/01 23:12:47 UTC

[jira] [Commented] (THRIFT-1192) Typo: TProtocol.h tests for HAVE_SYS_PARAM_H_

    [ https://issues.apache.org/jira/browse/THRIFT-1192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042440#comment-13042440 ] 

Hudson commented on THRIFT-1192:
--------------------------------

Integrated in Thrift #153 (See [https://builds.apache.org/hudson/job/Thrift/153/])
    THRIFT-1192: Typo: TProtocol.h tests for HAVE_SYS_PARAM_H_
Client: cpp
Patch: Eric Rannaud

Fixes the typo in the check for HAVE_SYS_PARAM_H

jfarrell : http://svn.apache.org/viewvc/?view=rev&rev=1130293
Files : 
* /thrift/trunk/lib/cpp/src/protocol/TProtocol.h


> Typo: TProtocol.h tests for HAVE_SYS_PARAM_H_
> ---------------------------------------------
>
>                 Key: THRIFT-1192
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1192
>             Project: Thrift
>          Issue Type: Bug
>    Affects Versions: 0.6.1, 0.7
>            Reporter: Eric Rannaud
>            Assignee: Eric Rannaud
>             Fix For: 0.7
>
>         Attachments: thrift-have-sys-param-typo.patch
>
>
> TProtocol.h tests for HAVE_SYS_PARAM_H_, which will never be defined, so <sys/param.h> is never included.
> Attached is a patch that fixes the typo on HAVE_SYS_PARAM_H, but I actually suspect that <sys/param.h> is not needed at all in the current codebase, as nobody reported a problem and I can't find any obvious need for it.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira