You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Dan Smith <ds...@pivotal.io> on 2016/05/17 23:58:29 UTC
Review Request 47503: GEODE-357: Remove third server from
testInitiateFailoverByCacheOperationThreads_Secondary
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47503/
-----------------------------------------------------------
Review request for geode and xiaojian zhou.
Repository: geode
Description
-------
This test was intermittently connecting to either 2 servers or 3. If the
test never connected to the third server, it would fail waiting for the
live server count to be 2.
Also cleaned up some code to use Awaitility and to have a lower ping
interval, because the ping is what causes us to disconnect from the
stopped server.
Diffs
-----
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/HAStartupAndFailoverDUnitTest.java 13f2527b92088ba0c87021f07a81657315aef396
Diff: https://reviews.apache.org/r/47503/diff/
Testing
-------
Thanks,
Dan Smith
Re: Review Request 47503: GEODE-357: Remove third server from
testInitiateFailoverByCacheOperationThreads_Secondary
Posted by xiaojian zhou <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47503/#review133694
-----------------------------------------------------------
Ship it!
Ship It!
- xiaojian zhou
On May 17, 2016, 11:58 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47503/
> -----------------------------------------------------------
>
> (Updated May 17, 2016, 11:58 p.m.)
>
>
> Review request for geode and xiaojian zhou.
>
>
> Repository: geode
>
>
> Description
> -------
>
> This test was intermittently connecting to either 2 servers or 3. If the
> test never connected to the third server, it would fail waiting for the
> live server count to be 2.
>
> Also cleaned up some code to use Awaitility and to have a lower ping
> interval, because the ping is what causes us to disconnect from the
> stopped server.
>
>
> Diffs
> -----
>
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/tier/sockets/HAStartupAndFailoverDUnitTest.java 13f2527b92088ba0c87021f07a81657315aef396
>
> Diff: https://reviews.apache.org/r/47503/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>