You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/01/10 19:02:52 UTC
[GitHub] [airflow] potiuk opened a new pull request #20791: Add example tests for Breeze2
potiuk opened a new pull request #20791:
URL: https://github.com/apache/airflow/pull/20791
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna commented on a change in pull request #20791: Add example tests for Breeze2
Posted by GitBox <gi...@apache.org>.
Bowrna commented on a change in pull request #20791:
URL: https://github.com/apache/airflow/pull/20791#discussion_r784800071
##########
File path: dev/breeze/src/airflow_breeze/breeze.py
##########
@@ -69,12 +69,14 @@ def find_airflow_sources_root():
os.chdir(__AIRFLOW_SOURCES_ROOT)
+find_airflow_sources_root()
Review comment:
Could you explain more about this part @potiuk ? I couldn't understand it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #20791: Add example tests for Breeze2
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #20791:
URL: https://github.com/apache/airflow/pull/20791
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] Bowrna commented on pull request #20791: Add example tests for Breeze2
Posted by GitBox <gi...@apache.org>.
Bowrna commented on pull request #20791:
URL: https://github.com/apache/airflow/pull/20791#issuecomment-1013072548
> Hey @Bowrna - as promised (little delayed) - here are example unit tests for Breeze. I am not sure yet how you'd feel about adding some more of thsose, but it woudl be great if in one of the next iterations at least some of the tests will be added so that you learn how to do it. I am happy to discuss it in a bit more detail when you are ready and explain how they work.
I will look into this Draft PR @potiuk .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #20791: Add example tests for Breeze2
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #20791:
URL: https://github.com/apache/airflow/pull/20791#issuecomment-1009251675
Hey @Bowrna - as promised (little delayed) - here are example unit tests for Breeze. I am not sure yet how you'd feel about adding some more of thsose, but it woudl be great if in one of the next iterations at least some of the tests will be added so that you learn how to do it. I am happy to discuss it in a bit more detail when you are ready and explain how they work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #20791: Add example tests for Breeze2
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #20791:
URL: https://github.com/apache/airflow/pull/20791#discussion_r781472915
##########
File path: dev/breeze/src/airflow_breeze/breeze.py
##########
@@ -69,12 +69,14 @@ def find_airflow_sources_root():
os.chdir(__AIRFLOW_SOURCES_ROOT)
+find_airflow_sources_root()
Review comment:
BTW. This something we will have to add later - but I will have to think how to do it best. this is just to get the example tests working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org