You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2015/09/09 16:43:06 UTC
Review Request 38214: Add a REASON for TASK_LOST with hard slave drain
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38214/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-2077
https://issues.apache.org/jira/browse/MESOS-2077
Repository: mesos
Description
-------
Ensure that TASK_LOST for a hard slave drain (SIGUSR1) include a
reason.
Diffs
-----
include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c
src/master/master.hpp e1331851c19e3372a4a525dcfd7ba2a01c3e97a6
src/master/master.cpp 5589eca4317b597de509f3387cfc349083b361ac
src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c
src/slave/slave.cpp 5e5522e1254a5ed6084de36782753f9aad2894c4
Diff: https://reviews.apache.org/r/38214/diff/
Testing
-------
Thanks,
Guangya Liu
Re: Review Request 38214: Add a REASON for TASK_LOST with hard slave
drain
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38214/#review98208
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38214]
All tests passed.
- Mesos ReviewBot
On Sept. 9, 2015, 2:43 p.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38214/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2015, 2:43 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-2077
> https://issues.apache.org/jira/browse/MESOS-2077
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ensure that TASK_LOST for a hard slave drain (SIGUSR1) include a
> reason.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto b1deed4720cab4a89db76a48bc9563bba4f5bf1c
> src/master/master.hpp e1331851c19e3372a4a525dcfd7ba2a01c3e97a6
> src/master/master.cpp 5589eca4317b597de509f3387cfc349083b361ac
> src/messages/messages.proto 8977d8e0f3b16003128b6b9cab556a7b224f083c
> src/slave/slave.cpp 5e5522e1254a5ed6084de36782753f9aad2894c4
>
> Diff: https://reviews.apache.org/r/38214/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 38214: PROTO: Added a REASON for TASK_LOST with
hard slave drain.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38214/
-----------------------------------------------------------
(Updated 十一月 4, 2015, 6:31 a.m.)
Review request for mesos and Ben Mahler.
Summary (updated)
-----------------
PROTO: Added a REASON for TASK_LOST with hard slave drain.
Bugs: MESOS-2077
https://issues.apache.org/jira/browse/MESOS-2077
Repository: mesos
Description
-------
Ensure that TASK_LOST for a hard slave drain (SIGUSR1) include a
reason.
Diffs
-----
include/mesos/mesos.proto 94004343ea615d87d7c7d63a6a81aaaa1cf8002e
include/mesos/v1/mesos.proto 8131778fe5c5f3a47ae9300a811e3d857a22da6a
src/messages/messages.proto 9a1564ff38fa1b984e92cb0abfde2108385f9e2a
Diff: https://reviews.apache.org/r/38214/diff/
Testing
-------
make
make check
Thanks,
Guangya Liu
Re: Review Request 38214: PROTO: Add a REASON for TASK_LOST with hard
slave drain
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38214/
-----------------------------------------------------------
(Updated 十一月 3, 2015, 8:21 a.m.)
Review request for mesos and Ben Mahler.
Summary (updated)
-----------------
PROTO: Add a REASON for TASK_LOST with hard slave drain
Bugs: MESOS-2077
https://issues.apache.org/jira/browse/MESOS-2077
Repository: mesos
Description
-------
Ensure that TASK_LOST for a hard slave drain (SIGUSR1) include a
reason.
Diffs (updated)
-----
include/mesos/mesos.proto 94004343ea615d87d7c7d63a6a81aaaa1cf8002e
include/mesos/v1/mesos.proto 8131778fe5c5f3a47ae9300a811e3d857a22da6a
src/messages/messages.proto 9a1564ff38fa1b984e92cb0abfde2108385f9e2a
Diff: https://reviews.apache.org/r/38214/diff/
Testing (updated)
-------
make
make check
Thanks,
Guangya Liu