You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Mike Klaas (JIRA)" <ji...@apache.org> on 2007/03/02 21:12:50 UTC
[jira] Created: (SOLR-176) Add detailed timing data to query
response output
Add detailed timing data to query response output
-------------------------------------------------
Key: SOLR-176
URL: https://issues.apache.org/jira/browse/SOLR-176
Project: Solr
Issue Type: New Feature
Components: search
Affects Versions: 1.2
Reporter: Mike Klaas
Assigned To: Mike Klaas
Priority: Minor
Fix For: 1.2
see http://www.nabble.com/%27accumulate%27-copyField-for-faceting-tf3329986.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-176) Add detailed timing data to query
response output
Posted by "Mike Klaas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Klaas updated SOLR-176:
----------------------------
Attachment: dtiming.patch
Same version with ASF license. Output format looks like:
<lst name="timing">
<double name="debug">13.0</double>
<double name="main query">1.0</double>
<double name="time">19.0</double>
<double name="setup/query parsing">5.0</double>
<double name="pre fetch">0.0</double>
</lst>
(Note that RTimer supports aritrary nesting of timers)
> Add detailed timing data to query response output
> -------------------------------------------------
>
> Key: SOLR-176
> URL: https://issues.apache.org/jira/browse/SOLR-176
> Project: Solr
> Issue Type: New Feature
> Components: search
> Affects Versions: 1.2
> Reporter: Mike Klaas
> Assigned To: Mike Klaas
> Priority: Minor
> Fix For: 1.2
>
> Attachments: dtiming.patch, dtiming.patch
>
>
> see http://www.nabble.com/%27accumulate%27-copyField-for-faceting-tf3329986.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-176) Add detailed timing data to query
response output
Posted by "Mike Klaas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Klaas updated SOLR-176:
----------------------------
Attachment: dtiming.patch
A quick version for people to play with. Includes a new timing class, plus timing data inserted into the dismax handler.
> Add detailed timing data to query response output
> -------------------------------------------------
>
> Key: SOLR-176
> URL: https://issues.apache.org/jira/browse/SOLR-176
> Project: Solr
> Issue Type: New Feature
> Components: search
> Affects Versions: 1.2
> Reporter: Mike Klaas
> Assigned To: Mike Klaas
> Priority: Minor
> Fix For: 1.2
>
> Attachments: dtiming.patch
>
>
> see http://www.nabble.com/%27accumulate%27-copyField-for-faceting-tf3329986.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-176) Add detailed timing data to query
response output
Posted by "Mike Klaas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Klaas updated SOLR-176:
----------------------------
Fix Version/s: (was: 1.2)
1.3
> Add detailed timing data to query response output
> -------------------------------------------------
>
> Key: SOLR-176
> URL: https://issues.apache.org/jira/browse/SOLR-176
> Project: Solr
> Issue Type: New Feature
> Components: search
> Affects Versions: 1.2
> Reporter: Mike Klaas
> Assignee: Mike Klaas
> Priority: Minor
> Fix For: 1.3
>
> Attachments: dtiming.patch, dtiming.patch, RequesthandlerBase.patch
>
>
> see http://www.nabble.com/%27accumulate%27-copyField-for-faceting-tf3329986.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-176) Add detailed timing data to query
response output
Posted by "Will Johnson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Will Johnson updated SOLR-176:
------------------------------
Attachment: RequesthandlerBase.patch
a slightly more ambitious patch that tracks:
* total number of requests/errors
* requests/errors in the current interval (interval defined in solrconfig)
* requets/errors as of the start of the last interval
* avg requet times for total / current interval
> Add detailed timing data to query response output
> -------------------------------------------------
>
> Key: SOLR-176
> URL: https://issues.apache.org/jira/browse/SOLR-176
> Project: Solr
> Issue Type: New Feature
> Components: search
> Affects Versions: 1.2
> Reporter: Mike Klaas
> Assignee: Mike Klaas
> Priority: Minor
> Fix For: 1.3
>
> Attachments: dtiming.patch, dtiming.patch, dtiming.patch, dtiming.patch, RequesthandlerBase.patch, RequesthandlerBase.patch
>
>
> see http://www.nabble.com/%27accumulate%27-copyField-for-faceting-tf3329986.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-176) Add detailed timing data to query
response output
Posted by "Mike Klaas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477446 ]
Mike Klaas commented on SOLR-176:
---------------------------------
Well, we could provide deltas of all the solr statistics, but I'm not sure if it provides much benefit over watching the stats page before and after executing a query.
What might be more useful if for the facet code to detect facet-cache-thrashing (evictions ~= insertions), and emit a performance warning in the logfile.
> Add detailed timing data to query response output
> -------------------------------------------------
>
> Key: SOLR-176
> URL: https://issues.apache.org/jira/browse/SOLR-176
> Project: Solr
> Issue Type: New Feature
> Components: search
> Affects Versions: 1.2
> Reporter: Mike Klaas
> Assigned To: Mike Klaas
> Priority: Minor
> Fix For: 1.2
>
>
> see http://www.nabble.com/%27accumulate%27-copyField-for-faceting-tf3329986.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-176) Add detailed timing data to query
response output
Posted by "Mike Klaas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mike Klaas updated SOLR-176:
----------------------------
Attachment: dtiming.patch
added javadocs for RTimer.java, and removed a superfluous line from SRH.java
> Add detailed timing data to query response output
> -------------------------------------------------
>
> Key: SOLR-176
> URL: https://issues.apache.org/jira/browse/SOLR-176
> Project: Solr
> Issue Type: New Feature
> Components: search
> Affects Versions: 1.2
> Reporter: Mike Klaas
> Assignee: Mike Klaas
> Priority: Minor
> Fix For: 1.3
>
> Attachments: dtiming.patch, dtiming.patch, dtiming.patch, dtiming.patch, RequesthandlerBase.patch
>
>
> see http://www.nabble.com/%27accumulate%27-copyField-for-faceting-tf3329986.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-176) Add detailed timing data to query
response output
Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12505395 ]
Ryan McKinley commented on SOLR-176:
------------------------------------
Will's RequesthandlerBase.patch addition is simple, straightforward, useful - i will add that now.
> Add detailed timing data to query response output
> -------------------------------------------------
>
> Key: SOLR-176
> URL: https://issues.apache.org/jira/browse/SOLR-176
> Project: Solr
> Issue Type: New Feature
> Components: search
> Affects Versions: 1.2
> Reporter: Mike Klaas
> Assignee: Mike Klaas
> Priority: Minor
> Fix For: 1.3
>
> Attachments: dtiming.patch, dtiming.patch, dtiming.patch, RequesthandlerBase.patch
>
>
> see http://www.nabble.com/%27accumulate%27-copyField-for-faceting-tf3329986.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-176) Add detailed timing data to query
response output
Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12505397 ]
Ryan McKinley commented on SOLR-176:
------------------------------------
>
> Might it then make sense to wait until the search component thing is done? Auto-timing everything would be easy.
>
Yes, i think so. but this is still useful for debuging in the meantime. (as a patch)
Will's addition is independent, it adds average timing info to RequestHandler statistics
> Add detailed timing data to query response output
> -------------------------------------------------
>
> Key: SOLR-176
> URL: https://issues.apache.org/jira/browse/SOLR-176
> Project: Solr
> Issue Type: New Feature
> Components: search
> Affects Versions: 1.2
> Reporter: Mike Klaas
> Assignee: Mike Klaas
> Priority: Minor
> Fix For: 1.3
>
> Attachments: dtiming.patch, dtiming.patch, dtiming.patch, RequesthandlerBase.patch
>
>
> see http://www.nabble.com/%27accumulate%27-copyField-for-faceting-tf3329986.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-176) Add detailed timing data to query
response output
Posted by "Mike Klaas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12505393 ]
Mike Klaas commented on SOLR-176:
---------------------------------
Might it then make sense to wait until the search component thing is done? Auto-timing everything would be easy.
> Add detailed timing data to query response output
> -------------------------------------------------
>
> Key: SOLR-176
> URL: https://issues.apache.org/jira/browse/SOLR-176
> Project: Solr
> Issue Type: New Feature
> Components: search
> Affects Versions: 1.2
> Reporter: Mike Klaas
> Assignee: Mike Klaas
> Priority: Minor
> Fix For: 1.3
>
> Attachments: dtiming.patch, dtiming.patch, dtiming.patch, RequesthandlerBase.patch
>
>
> see http://www.nabble.com/%27accumulate%27-copyField-for-faceting-tf3329986.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work started: (SOLR-176) Add detailed timing data to query
response output
Posted by "Mike Klaas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on SOLR-176 started by Mike Klaas.
> Add detailed timing data to query response output
> -------------------------------------------------
>
> Key: SOLR-176
> URL: https://issues.apache.org/jira/browse/SOLR-176
> Project: Solr
> Issue Type: New Feature
> Components: search
> Affects Versions: 1.2
> Reporter: Mike Klaas
> Assigned To: Mike Klaas
> Priority: Minor
> Fix For: 1.2
>
> Attachments: dtiming.patch
>
>
> see http://www.nabble.com/%27accumulate%27-copyField-for-faceting-tf3329986.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-176) Add detailed timing data to query
response output
Posted by "Will Johnson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Will Johnson updated SOLR-176:
------------------------------
Attachment: RequesthandlerBase.patch
added some average stats to RequestHandlerBase. all of the same info can be obtained by parsing the log files but having it show up on the admin screens and jmx is simple and nice to have. stats added: avgTimePerRequest and avgRequestsPerSecond.
> Add detailed timing data to query response output
> -------------------------------------------------
>
> Key: SOLR-176
> URL: https://issues.apache.org/jira/browse/SOLR-176
> Project: Solr
> Issue Type: New Feature
> Components: search
> Affects Versions: 1.2
> Reporter: Mike Klaas
> Assigned To: Mike Klaas
> Priority: Minor
> Fix For: 1.2
>
> Attachments: dtiming.patch, dtiming.patch, RequesthandlerBase.patch
>
>
> see http://www.nabble.com/%27accumulate%27-copyField-for-faceting-tf3329986.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SOLR-176) Add detailed timing data to query
response output
Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan McKinley updated SOLR-176:
-------------------------------
Attachment: dtiming.patch
* applies with trunk.
* added timing info to StandardRequestHandler
I think this will make lots of sense in the context of search components:
http://www.nabble.com/search-components-%28plugins%29-tf3898040.html
> Add detailed timing data to query response output
> -------------------------------------------------
>
> Key: SOLR-176
> URL: https://issues.apache.org/jira/browse/SOLR-176
> Project: Solr
> Issue Type: New Feature
> Components: search
> Affects Versions: 1.2
> Reporter: Mike Klaas
> Assignee: Mike Klaas
> Priority: Minor
> Fix For: 1.3
>
> Attachments: dtiming.patch, dtiming.patch, dtiming.patch, RequesthandlerBase.patch
>
>
> see http://www.nabble.com/%27accumulate%27-copyField-for-faceting-tf3329986.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-176) Add detailed timing data to query
response output
Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12477439 ]
Ryan McKinley commented on SOLR-176:
------------------------------------
If possible, it would also be nice to include the change in cache sizes from the beginning to the end of the request. This would help optimize cache sizes for faceting.
thanks
> Add detailed timing data to query response output
> -------------------------------------------------
>
> Key: SOLR-176
> URL: https://issues.apache.org/jira/browse/SOLR-176
> Project: Solr
> Issue Type: New Feature
> Components: search
> Affects Versions: 1.2
> Reporter: Mike Klaas
> Assigned To: Mike Klaas
> Priority: Minor
> Fix For: 1.2
>
>
> see http://www.nabble.com/%27accumulate%27-copyField-for-faceting-tf3329986.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-176) Add detailed timing data to query
response output
Posted by "Mike Klaas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482289 ]
Mike Klaas commented on SOLR-176:
---------------------------------
Anyone else have an opinion on timing? It would be easy for me to wrap StandardRequestHandler similarly and commit.
If I add a test or two and put a warning about RTimer being not part of the official solr programmable api, then backward concerns should be limited to the response output. (Otherwise it is likely necessary to think about the design of the RTimer api).
> Add detailed timing data to query response output
> -------------------------------------------------
>
> Key: SOLR-176
> URL: https://issues.apache.org/jira/browse/SOLR-176
> Project: Solr
> Issue Type: New Feature
> Components: search
> Affects Versions: 1.2
> Reporter: Mike Klaas
> Assigned To: Mike Klaas
> Priority: Minor
> Fix For: 1.2
>
> Attachments: dtiming.patch, dtiming.patch
>
>
> see http://www.nabble.com/%27accumulate%27-copyField-for-faceting-tf3329986.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-176) Add detailed timing data to query
response output
Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478252 ]
Ryan McKinley commented on SOLR-176:
------------------------------------
works great for me. thanks!
nesting timers is really nice.
> Add detailed timing data to query response output
> -------------------------------------------------
>
> Key: SOLR-176
> URL: https://issues.apache.org/jira/browse/SOLR-176
> Project: Solr
> Issue Type: New Feature
> Components: search
> Affects Versions: 1.2
> Reporter: Mike Klaas
> Assigned To: Mike Klaas
> Priority: Minor
> Fix For: 1.2
>
> Attachments: dtiming.patch, dtiming.patch
>
>
> see http://www.nabble.com/%27accumulate%27-copyField-for-faceting-tf3329986.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-176) Add detailed timing data to query
response output
Posted by "Ryan McKinley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-176?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan McKinley resolved SOLR-176.
--------------------------------
Resolution: Fixed
Committed as part of SOLR-281
> Add detailed timing data to query response output
> -------------------------------------------------
>
> Key: SOLR-176
> URL: https://issues.apache.org/jira/browse/SOLR-176
> Project: Solr
> Issue Type: New Feature
> Components: search
> Affects Versions: 1.2
> Reporter: Mike Klaas
> Assignee: Mike Klaas
> Priority: Minor
> Fix For: 1.3
>
> Attachments: dtiming.patch, dtiming.patch, dtiming.patch, dtiming.patch, RequesthandlerBase.patch, RequesthandlerBase.patch
>
>
> see http://www.nabble.com/%27accumulate%27-copyField-for-faceting-tf3329986.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-176) Add detailed timing data to query
response output
Posted by "Hoss Man (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12482550 ]
Hoss Man commented on SOLR-176:
-------------------------------
i don't have any strong opinions, but i agree with your plan about putting some warnings in the RTTimer javadocs.
Random thought: it might be cleaner/easier in the long run to create/register a hog Handler that records timing differences and add calls to Logger.entering and Logger.exiting on the various methods.
someone may have already implemented such a Handler
> Add detailed timing data to query response output
> -------------------------------------------------
>
> Key: SOLR-176
> URL: https://issues.apache.org/jira/browse/SOLR-176
> Project: Solr
> Issue Type: New Feature
> Components: search
> Affects Versions: 1.2
> Reporter: Mike Klaas
> Assigned To: Mike Klaas
> Priority: Minor
> Fix For: 1.2
>
> Attachments: dtiming.patch, dtiming.patch
>
>
> see http://www.nabble.com/%27accumulate%27-copyField-for-faceting-tf3329986.html
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.