[GitHub] [incubator-nuttx] davids5 commented on pull request #3517: arch: Allocate the space from the beginning in up_stack_frame

[GitBox <gi...@apache.org>]

davids5 commented on pull request #3517:
URL: https://github.com/apache/incubator-nuttx/pull/3517#issuecomment-817310256


   The names do not carry enough context and are still too confusing.  
   
   The Deinitions should be clearer - This one is not so bad, the the description can use some work 
   ``stack_alloc_ptr``: Pointer to the memory allocated for the stack and optional TLS this is the base address returned by an alloc operation.
   
   
   This one needs work:
   
   ``adj_stack_ptr``: Adjusted ``stack_alloc_ptr`` for HW. - add information as to why it is adjusted in the comment.
   
   Then consider changing the name - See it is not a stack pointer and yet is is called  adj_stack_ptr -> adj_stackbase_ptr


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org