[GitHub] [doris] BePPPower commented on a diff in pull request #12239: [enhancement](http) executeSQL controller support streaming response

[GitBox <gi...@apache.org>]

BePPPower commented on code in PR #12239:
URL: https://github.com/apache/doris/pull/12239#discussion_r960145675


##########
fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/StmtExecutionAction.java:
##########
@@ -100,7 +100,11 @@ public Object executeSQL(@PathVariable(value = NS_KEY) String ns, @PathVariable(
 
         ConnectContext.get().changeDefaultCatalog(ns);
         ConnectContext.get().setDatabase(getFullDbName(dbName));
-        return executeQuery(authInfo, stmtRequestBody.is_sync, stmtRequestBody.limit, stmtRequestBody);
+
+        String streamHeader = request.getHeader("X-Doris-Stream");
+        boolean isStream = !("false".equalsIgnoreCase(streamHeader));

Review Comment:
   Because I think stream should be default behavior, and can close it by setting `streamHeader: false`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org