You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by pu...@apache.org on 2015/09/02 09:23:08 UTC

[3/3] cordova-plugin-statusbar git commit: removed proxy and renamed platform file, merge instead of clobber, fixed failing tests for missing methods.

removed proxy and renamed platform file, merge instead of clobber,  fixed failing tests for missing methods.


Project: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/commit/b0b61af6
Tree: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/tree/b0b61af6
Diff: http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/diff/b0b61af6

Branch: refs/heads/master
Commit: b0b61af61a6c3ab0948657b77608dd906cee517b
Parents: da924e1
Author: Jesse MacFadyen <pu...@gmail.com>
Authored: Wed Sep 2 00:22:57 2015 -0700
Committer: Jesse MacFadyen <pu...@gmail.com>
Committed: Wed Sep 2 00:22:57 2015 -0700

----------------------------------------------------------------------
 plugin.xml                    |  4 ++--
 src/browser/StatusBarProxy.js | 40 ---------------------------------
 src/browser/statusbar.js      | 45 ++++++++++++++++++++++++++++++++++++++
 3 files changed, 47 insertions(+), 42 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/blob/b0b61af6/plugin.xml
----------------------------------------------------------------------
diff --git a/plugin.xml b/plugin.xml
index 66e8490..f898f19 100644
--- a/plugin.xml
+++ b/plugin.xml
@@ -48,8 +48,8 @@
     </platform>
 
     <platform name="browser">
-        <js-module src="src/browser/StatusBarProxy.js" name="StatusBarProxy">
-            <clobbers target="window.StatusBar" />
+        <js-module src="src/browser/statusbar.js" name="statusbar">
+            <merges target="window.StatusBar" />
         </js-module>
     </platform>
 

http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/blob/b0b61af6/src/browser/StatusBarProxy.js
----------------------------------------------------------------------
diff --git a/src/browser/StatusBarProxy.js b/src/browser/StatusBarProxy.js
deleted file mode 100644
index 6c06673..0000000
--- a/src/browser/StatusBarProxy.js
+++ /dev/null
@@ -1,40 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *   http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied.  See the License for the
- * specific language governing permissions and limitations
- * under the License.
- *
- */
-
-var cordova = require('cordova');
-
-function notSupported() {
-    console.log('StatusBar is not supported');
-    return false;
-}
-
-module.exports = {
-    overlaysWebView: notSupported,
-    styleDefault: notSupported,
-    styleLightContect: notSupported,
-    styleBlackTranslucent: notSupported,
-    styleBlackOpaque: notSupported,
-    backgroundColorByName: notSupported,
-    backgroundColorByHexString: notSupported,
-    hide: notSupported,
-    show: notSupported
-};
-
-require('cordova/exec/proxy').add('StatusBar', module.exports);

http://git-wip-us.apache.org/repos/asf/cordova-plugin-statusbar/blob/b0b61af6/src/browser/statusbar.js
----------------------------------------------------------------------
diff --git a/src/browser/statusbar.js b/src/browser/statusbar.js
new file mode 100644
index 0000000..ed5b00d
--- /dev/null
+++ b/src/browser/statusbar.js
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+ */
+
+var cordova = require('cordova');
+
+function notSupported() {
+    console.log('StatusBar is not supported');
+    return false;
+}
+
+module.exports = {
+    isVisible: false,
+    styleBlackTranslucent:notSupported,
+    styleDefault:notSupported,
+    styleLightContent:notSupported,
+    styleBlackOpaque:notSupported,
+    overlaysWebView:notSupported,
+    overlaysWebView: notSupported,
+    styleDefault: notSupported,
+    styleLightContect: notSupported,
+    styleBlackTranslucent: notSupported,
+    styleBlackOpaque: notSupported,
+    backgroundColorByName: notSupported,
+    backgroundColorByHexString: notSupported,
+    hide: notSupported,
+    show: notSupported
+};
+


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org