You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/20 10:50:07 UTC

[GitHub] [spark] dengziming opened a new pull request, #39138: [SPARK-41334][CONNECT][FOLLOWUP] Handle SortOrder Expression

dengziming opened a new pull request, #39138:
URL: https://github.com/apache/spark/pull/39138

   
   ### What changes were proposed in this pull request?
   in #39090 we moved `SortOrder` proto from relations to expressions, in this PR we add logic to handle it.
   
   ### Why are the changes needed?
   [<!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->](https://github.com/dengziming/spark/pull/new/SortOrder)
   
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   A unit test and existing tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zhengruifeng closed pull request #39138: [SPARK-41334][CONNECT][FOLLOWUP] Handle SortOrder Expression

Posted by GitBox <gi...@apache.org>.
zhengruifeng closed pull request #39138: [SPARK-41334][CONNECT][FOLLOWUP] Handle SortOrder Expression
URL: https://github.com/apache/spark/pull/39138


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #39138: [SPARK-41334][CONNECT][FOLLOWUP] Handle SortOrder Expression

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on PR #39138:
URL: https://github.com/apache/spark/pull/39138#issuecomment-1359179720

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] dengziming commented on pull request #39138: [SPARK-41334][CONNECT][FOLLOWUP] Handle SortOrder Expression

Posted by GitBox <gi...@apache.org>.
dengziming commented on PR #39138:
URL: https://github.com/apache/spark/pull/39138#issuecomment-1359172383

   cc @zhengruifeng 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zhengruifeng commented on pull request #39138: [SPARK-41334][CONNECT][FOLLOWUP] Handle SortOrder Expression

Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #39138:
URL: https://github.com/apache/spark/pull/39138#issuecomment-1360617326

   merged into master, thank you @dengziming 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org