You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/16 09:07:04 UTC
[GitHub] [cloudstack] davidjumani opened a new pull request #4410: Ensuring only vms on KVM honour UEFI boot type
davidjumani opened a new pull request #4410:
URL: https://github.com/apache/cloudstack/pull/4410
## Description
Ensuring only VMs on KVM honour UEFI boot type
VMware does not honour boot type for templates, so throwing an error if it is passed (since only KVM and VMware support it)
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
## How Has This Been Tested?
TODO
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4410: Throwing error if boot type or boot mode specified while deploying VMs on VMware
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4410:
URL: https://github.com/apache/cloudstack/pull/4410#issuecomment-709946510
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4410: Ensuring only vms on KVM honour UEFI boot type
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4410:
URL: https://github.com/apache/cloudstack/pull/4410#issuecomment-709927322
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani closed pull request #4410: Throwing error if boot type or boot mode specified while deploying VMs on VMware
Posted by GitBox <gi...@apache.org>.
davidjumani closed pull request #4410:
URL: https://github.com/apache/cloudstack/pull/4410
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] andrijapanicsb commented on pull request #4410: Throwing error if boot type or boot mode specified while deploying VMs on VMware
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #4410:
URL: https://github.com/apache/cloudstack/pull/4410#issuecomment-709947014
Let's please move this one on top of the PR4307, as it is very related - easier to test. THx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4410: Throwing error if boot type or boot mode specified while deploying VMs on VMware
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4410:
URL: https://github.com/apache/cloudstack/pull/4410#issuecomment-709946903
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] davidjumani commented on pull request #4410: Throwing error if boot type or boot mode specified while deploying VMs on VMware
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #4410:
URL: https://github.com/apache/cloudstack/pull/4410#issuecomment-710021192
Added https://github.com/apache/cloudstack/pull/4307/commits/d0180fb0260d9f05c277ade935861024913fa95b
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4410: Throwing error if boot type or boot mode specified while deploying VMs on VMware
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4410:
URL: https://github.com/apache/cloudstack/pull/4410#issuecomment-709966574
Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2197
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4410: Ensuring only vms on KVM honour UEFI boot type
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4410:
URL: https://github.com/apache/cloudstack/pull/4410#issuecomment-709927919
@davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #4410: Throwing error if boot type or boot mode specified while deploying VMs on VMware
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #4410:
URL: https://github.com/apache/cloudstack/pull/4410#issuecomment-709982515
looks good but agree with @andrijapanicsb , this is (only) valuable in combination with that PR, @davidjumani
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org