You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mahout.apache.org by GitBox <gi...@apache.org> on 2020/07/14 18:29:34 UTC

[GitHub] [mahout] balashashanka opened a new pull request #401: MAHOUT-2096 - next() Called On Possible Empty iterator()

balashashanka opened a new pull request #401:
URL: https://github.com/apache/mahout/pull/401


   ### Purpose of PR:
   Initially there was no check for the empty iterator when calling the next() function, which could result in an exception.
   
   ### Important ToDos
   Please mark each with an "x"
   - [ x ] A JIRA ticket exists (if not, please create this first)[https://issues.apache.org/jira/browse/mahout/]
   - [ x ] Title of PR is "MAHOUT-XXXX Brief Description of Changes" where XXXX is the JIRA number.
   - [ ] Created unit tests where appropriate
   - [ ] Added licenses correct on newly added files
   - [ ] Assigned JIRA to self
   - [ ] Added documentation in scala docs/java docs, and to website
   - [ x ] Successfully built and ran all unit tests, verified that all tests pass locally.
   
   If all of these things aren't complete, but you still feel it is
   appropriate to open a PR, please add [WIP] after MAHOUT-XXXX before the
   descriptions- e.g. "MAHOUT-XXXX [WIP] Description of Change"
   
   Does this change break earlier versions? - No 
   
   Is this the beginning of a larger project for which a feature branch should be made? - Not sure
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mahout] balashashanka commented on pull request #401: MAHOUT-2096 [WIP] next() Called On Possible Empty iterator()

Posted by GitBox <gi...@apache.org>.
balashashanka commented on pull request #401:
URL: https://github.com/apache/mahout/pull/401#issuecomment-658360710


   Sure thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mahout] rawkintrevo commented on pull request #401: MAHOUT-2096 [WIP] next() Called On Possible Empty iterator()

Posted by GitBox <gi...@apache.org>.
rawkintrevo commented on pull request #401:
URL: https://github.com/apache/mahout/pull/401#issuecomment-658350964


   Thanks for the contribution @balashashanka  !
   
   lgtm- however, 
   1. We're in a code freeze at the moment as we're attmpeting to release 14.1 and only merging PRs relevant to release blockers
   2. There was a moratorium on MR commits, however, I think we can allow this as I'm not sure that holds any more and also this is a maintenance patch. 
   
   Will discuss and (probably) merge after release.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org