[GitHub] [druid] loquisgon commented on a change in pull request #10736: Fix potential deadlock in batch ingestion

[GitBox <gi...@apache.org>]

loquisgon commented on a change in pull request #10736:
URL: https://github.com/apache/druid/pull/10736#discussion_r553578192



##########
File path: indexing-service/src/main/java/org/apache/druid/indexing/common/task/AbstractBatchIndexTask.java
##########
@@ -409,13 +413,19 @@ protected boolean tryTimeChunkLock(TaskActionClient client, List<Interval> inter
       }
     }
 
-    for (Interval interval : uniqueIntervals) {
-      final TaskLock lock = client.submit(new TimeChunkLockTryAcquireAction(TaskLockType.EXCLUSIVE, interval));
-      if (lock == null) {
-        return false;
-      }
-    }
-    return true;
+    // This method is called isReady() which is called in the Overlord to check if the task is ready for execution.

Review comment:
       This method is called by the `isReady` method elsewhere (comment: it'd be nice to explain where the `isReady` method lives...)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org