[jira] [Commented] (GEODE-4091) LRUListWithAsyncSorting.createExecutor needs to configure ThreadFactory and ThreadGroup

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-4091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16289806#comment-16289806 ] 

ASF GitHub Bot commented on GEODE-4091:
---------------------------------------

dschneider-pivotal opened a new pull request #1165: GEODE-4091: add ThreadFactory for evictor
URL: https://github.com/apache/geode/pull/1165
 
 
   The threads created to do background eviction scanning
   will now be named "LRUListWithAsyncSortingThreadNNN".
   The will now be daemon threads.
   They now have an unhandled exception handler.
   Their group is named "LRUListWithAsyncSorting Threads".
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> LRUListWithAsyncSorting.createExecutor needs to configure ThreadFactory and ThreadGroup
> ---------------------------------------------------------------------------------------
>
>                 Key: GEODE-4091
>                 URL: https://issues.apache.org/jira/browse/GEODE-4091
>             Project: Geode
>          Issue Type: Bug
>          Components: eviction
>    Affects Versions: 1.4.0
>            Reporter: Darrel Schneider
>            Assignee: Darrel Schneider
>
> The new LRUListWithAsyncSorting.createExecutor does not configure thread names nor a thread group. The ThreadGroup is important so that unhandled exceptions in these threads will be logged.
> The thread names help in debugging stack dumps.
> Also, these threads are currently non-daemon so they could cause the shutdown of the JVM to hang.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)