[GitHub] brooklyn-server issue #509: [wip] Add Azure Location

[aledsage <gi...@git.apache.org>]

Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-server/pull/509
  
    @drigodwin looks good. In what way is this still "work in progress"?
    
    Looking at how features are defined in https://github.com/jclouds/jclouds-karaf/blob/master/feature/src/main/resources/feature.xml, I wonder if we want to (overengineer?!) structure it like:
    ```
        <!--
            Features for providers defined in jclouds-labs, similar to the way core providers are defined in
            https://github.com/jclouds/jclouds-karaf/blob/rel/jclouds-karaf-2.0.0/feature/src/main/resources/feature.xml
        -->
        <feature name="jclouds-labs-azurecompute" description='Components to access Azure Compute Classic' version="${jclouds.version}">
            <feature version='${jclouds.version}'>jclouds-compute</feature>
            <bundle>mvn:org.apache.jclouds.labs/azurecompute/${jclouds.version}</bundle>
        </feature>
    
        <feature name="jclouds-labs-azurecompute-arm" description='Components to access Azure Compute (ARM)' version="${jclouds.version}">
            <feature version='${jclouds.version}'>jclouds-compute</feature>
            <bundle dependency="true">mvn:org.apache.jclouds.api/oauth/${jclouds.version}</bundle>
            <bundle>mvn:org.apache.jclouds.labs/azurecompute-arm/${jclouds.version}</bundle>
        </feature>
    ```
    
    And then include those features in the feature `brooklyn-locations-jclouds`.
    
    ---
    As an aside (for different PR), we can now use the jclouds feature `jclouds-google-compute-engine` rather than us having to explicitly depend on the bundle.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---