You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/19 23:23:00 UTC
[GitHub] [airflow] mik-laj opened a new pull request #9421: Fix pylint issues in some airflow/www/* files
mik-laj opened a new pull request #9421:
URL: https://github.com/apache/airflow/pull/9421
---
Make sure to mark the boxes below before creating PR: [x]
- [X] Description above provides context of the change
- [X] Unit tests coverage for changes (not needed for documentation changes)
- [X] Target Github ISSUE in description if exists
- [X] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [X] Relevant documentation is updated including usage instructions.
- [X] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #9421: Fix pylint issues in some airflow/www/* files
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #9421:
URL: https://github.com/apache/airflow/pull/9421
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #9421: Fix pylint issues in some airflow/www/* files
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #9421:
URL: https://github.com/apache/airflow/pull/9421#discussion_r443114210
##########
File path: airflow/www/forms.py
##########
@@ -129,23 +143,84 @@ class DagRunForm(DynamicForm):
lazy_gettext('External Trigger'))
conf = TextAreaField(
lazy_gettext('Conf'),
- validators=[ValidJson(), validators.Optional()],
+ validators=[ValidJson(), Optional()],
widget=BS3TextAreaFieldWidget())
def populate_obj(self, item):
- super().populate_obj(item)
+ """Populates the attributes of the passed obj with data from the form’s fields."""
+ super().populate_obj(item) # pylint: disable=no-member
item.run_type = DagRunType.from_run_id(item.run_id).value
if item.conf:
item.conf = json.loads(item.conf)
+_connection_types = [
Review comment:
Nice. This is exactly where it belongs!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org