You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by mwkang <gi...@git.apache.org> on 2016/07/30 05:52:00 UTC
[GitHub] zeppelin pull request #1248: [ZEPPELIN-1069]Ignore implicit interpreter when...
GitHub user mwkang opened a pull request:
https://github.com/apache/zeppelin/pull/1248
[ZEPPELIN-1069]Ignore implicit interpreter when user enter wrong interpreter name
### What is this PR for?
Ignore implicit interpreter when user enter wrong interpreter name
linked to https://github.com/apache/zeppelin/pull/806#issuecomment-227041293
This PR is related to #1113
ZEPPELIN-1069 branch was force push, so couldn't reopen that PR.
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1069
### How should this be tested?
Unit test
Run-time checking
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mwkang/zeppelin ZEPPELIN-1069
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1248.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1248
----
commit 0b3cb383870e77037b79035c34a6dd146fb37ec0
Author: Minwoo Kang <mi...@outlook.com>
Date: 2016-07-29T07:21:53Z
Add function that is replName is binding.
commit d1c074887dc419a68014b912e0ed852d8d029df7
Author: Minwoo Kang <mi...@outlook.com>
Date: 2016-07-30T05:31:10Z
Add test cases
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1248
> If you re-trigger CI more (close&re-open this PR) - does the same issue persists every time?
I'm not sure if it persists. I will re-tigger after fix the issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1248
Do you check the error of CI?
```
Failed tests:
NoteTest.insertParagraphWithLastReplName:159 expected:<%spark > but was:<null>
NoteTest.addParagraphWithLastReplName:144 expected:<%spark > but was:<null>
```
I think it's meaningful error and it needs to be fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1248
@bzz Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1248
This looks like an issue fixed in master 10h ago:
```
[31m- should provide onclick method *** FAILED ***[0m
[31m The code passed to eventually never returned normally. Attempted 1 times over 231.694296 milliseconds. Last failure message: 0 was not equal to 1. (AbstractAngularElemTest.scala:72)[0m
```
Could you please try rebasing on latest master `git pull ; git rebase master; git push -f` ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1248
Thanks! In my experience, if in case of CI failure PR author posts the failure result from logs - that speeds us review a lot!
CI fails now on Spark 1.6 Scala 2.10 and Scala 2.11 profiles with
```
[INFO] Zeppelin: web Application .......................... FAILURE [01:31 min]
[INFO] make: Leaving directory `/home/travis/build/apache/zeppelin/zeppelin-web/node_modules/karma/node_modules/socket.io/node_modules/socket.io-client/node_modules/ws/build'
[ERROR] npm ERR! Linux 3.13.0-40-generic
[ERROR] npm ERR! argv "/home/travis/build/apache/zeppelin/zeppelin-web/node/node" "/home/travis/build/apache/zeppelin/zeppelin-web/node/node_modules/npm/bin/npm-cli.js" "install" "--color=false"
[ERROR] npm ERR! node v0.12.13
[ERROR] npm ERR! npm v2.15.0
[ERROR] npm ERR! code ECONNRESET
[ERROR] npm ERR! errno ECONNRESET
[ERROR] npm ERR! syscall read
[ERROR]
[ERROR] npm ERR! network read ECONNRESET
[ERROR] npm ERR! network This is most likely not a problem with npm itself
[ERROR] npm ERR! network and is related to network connectivity.
[ERROR] npm ERR! network In most cases you are behind a proxy or have bad network settings.
[ERROR] npm ERR! network
[ERROR] npm ERR! network If you are behind a proxy, please make sure that the
[ERROR] npm ERR! network 'proxy' config is set properly. See: 'npm help config'
```
Which seems to be networking issue on Travis side \U0001f612
Thank you @mwkang , looks great to me, merging to master if there is no further discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1248
@bzz I think This PR have some trouble merging to master.
Because When bzz leave comment, I also leave comment immediately.
So bot did not recognize this PR.
Could you mind if you check again? (I'm worried about this PR open forever.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1248
I'm sorry for delay, @mwkang - my plate was full last week.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1248
@bzz No, It does not persists every time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1248
@bzz I'm worried about that `static import` confused.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1248
@bzz I changed StringUtils is static import. Can you check the code?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1248
ping @bzz
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1248
I refactor method name.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1248
@jongyoul Sorry, I missed it. I will check. I appreciate your review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1248
> @bzz ~~Thanks for comment, But could you explain more why it doesn't make sense?~~
Ah.. Your meaning is that org.apache.zeppelin.interpreter.InterpreterFactory#isBinded move to Note.java. Is it right?
Yes, that is exactly what I meant @mwkang !
And while doing so, readability of the piece of the code you are changing could also be improved with static import.
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1248
@mwkang thank you for friendly ping!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1248
Thank you for your patience @mwkang !
Sorry for the late notice, but could you please take a look and make sure that code conforms the project styleguilde?
Will merge to master asap, right after that, if there is no further discussion!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1248: [ZEPPELIN-1069]Ignore implicit interpreter when...
Posted by mwkang <gi...@git.apache.org>.
GitHub user mwkang reopened a pull request:
https://github.com/apache/zeppelin/pull/1248
[ZEPPELIN-1069]Ignore implicit interpreter when user enter wrong interpreter name
### What is this PR for?
Ignore implicit interpreter when user enter wrong interpreter name
linked to https://github.com/apache/zeppelin/pull/806#issuecomment-227041293
This PR is related to #1113
ZEPPELIN-1069 branch was force push, so couldn't reopen that PR.
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1069
### How should this be tested?
Unit test
Run-time checking
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mwkang/zeppelin ZEPPELIN-1069
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1248.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1248
----
commit 0b3cb383870e77037b79035c34a6dd146fb37ec0
Author: Minwoo Kang <mi...@outlook.com>
Date: 2016-07-29T07:21:53Z
Add function that is replName is binding.
commit d1c074887dc419a68014b912e0ed852d8d029df7
Author: Minwoo Kang <mi...@outlook.com>
Date: 2016-07-30T05:31:10Z
Add test cases
commit c3b5ddd0891a534ff015b02048b293e8c45b5e22
Author: Minwoo Kang <mi...@outlook.com>
Date: 2016-08-03T04:49:15Z
Refactor method name
commit ab8e78f9bcf037b46ced635966df59b61b695966
Author: Minwoo Kang <mi...@outlook.com>
Date: 2016-08-05T01:28:30Z
Modify that StringUtils is static import
commit c0f2af06d61c2e7b627eafbe471828898c8cef39
Author: Minwoo Kang <mi...@outlook.com>
Date: 2016-08-05T14:47:17Z
Modify static import position.
commit a8eede2fd24a647401e03f8149bef6d7e81754b4
Author: Minwoo Kang <mi...@outlook.com>
Date: 2016-08-08T14:58:24Z
Fixed CI
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1248: [ZEPPELIN-1069]Ignore implicit interpreter when...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang closed the pull request at:
https://github.com/apache/zeppelin/pull/1248
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1248
Ok, good to know, let me look into that
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...
Posted by astroshim <gi...@git.apache.org>.
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1248
tested. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1248
\U0001f44d for having a test!
Looks good to me, modulo the issue raised above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1248
@bzz Thanks for your review. I rebase on to master and force push.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1248: [ZEPPELIN-1069]Ignore implicit interpreter when...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1248
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1248
@jongyoul Can you review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1248
I am not sure this error is related with this issue.
```
Failed tests:
ZeppelinSparkClusterTest.zRunTest:204 expected:<FINISHED> but was:<ERROR>
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1248
@mwkang thank you for prompt addressing reviews!
If you re-trigger CI more (close&re-open this PR) - does the same issue persists every time?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...
Posted by mwkang <gi...@git.apache.org>.
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1248
re-trigger CI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---