[jira] [Commented] (DRILL-8009) DrillConnectionImpl#isValid() doesn't correspond JDBC API

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-8009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438750#comment-17438750 ] 

ASF GitHub Bot commented on DRILL-8009:
---------------------------------------

rymarm commented on pull request #2333:
URL: https://github.com/apache/drill/pull/2333#issuecomment-961055102


   @paul-rogers Hello! Could you, please, review my fix? I've rewritten my previous code totally and made it in "netty style" to make it thread-safe, extensible and simple to understand.
   
   Besides this, I've also:
   - corrected `DrillConnectionImpl#close()` so it worked correctly and could catch cases, when netty`s connection was closed;
   - overrided  `AvaticaConnection#close()` in `DrillConnectionImpl` so it now correctly implement `Autocloseable` interface.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> DrillConnectionImpl#isValid() doesn't correspond JDBC API
> ---------------------------------------------------------
>
>                 Key: DRILL-8009
>                 URL: https://issues.apache.org/jira/browse/DRILL-8009
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Client - JDBC
>            Reporter: Maksym Rymar
>            Assignee: Maksym Rymar
>            Priority: Major
>
> {{DrillConnectionImpl#isValid()}} doesn't correspond [Java JDBC API documentation|https://docs.oracle.com/javase/7/docs/api/java/sql/Connection.html#isValid(int)]. Current implementation doesn't do actual connection verify and doesn't cover cases like drillbit termination and network issues.
> {{java.sql.Connection#isValid()}} (which extends {{DrillConnectionImpl}}) widely used in JDBC connection pools like HikariCP and without right implementation, Drill JDBC driver cannot be used with them, because connections will keep alive forever.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)