You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/08/03 23:21:00 UTC

[jira] [Commented] (AIRFLOW-2847) Remove deprecated plugin import support

    [ https://issues.apache.org/jira/browse/AIRFLOW-2847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16568907#comment-16568907 ] 

ASF GitHub Bot commented on AIRFLOW-2847:
-----------------------------------------

holdenk opened a new pull request #3692: [AIRFLOW-2847][WIP] Remove legacy imports support for plugins
URL: https://github.com/apache/incubator-airflow/pull/3692
 
 
   [AIRFLOW-2847] Remove legacy imports support for plugins
   
   This is a WIP since the tests on master aren't passing locally on my machine (5 out of 8 for `./run_unit_tests.sh  ./tests/plugins_manager.py` pass), I'll drop the WIP if this passes CI.
   
   ### Jira
   
   - [ X ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   ### Tests
   
   - [ X ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   Existing unit tests for plugins.
   
   ### Commits
   
   - [ X ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
   
   ### Code Quality
   
   - [ X ] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Remove deprecated plugin import support
> ---------------------------------------
>
>                 Key: AIRFLOW-2847
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2847
>             Project: Apache Airflow
>          Issue Type: Improvement
>    Affects Versions: Airflow 2.0
>            Reporter: holdenk
>            Assignee: holdenk
>            Priority: Major
>
> As stated in the TODOs in macros,sensors, etc. we should remove the old import mechanism for 2.0 since its been deprecated with 2.0 as the slated removal time-frame.
>  
> Note: I made the issue "Major" but it _might_ be a blocker but since it's listed as to be removed in 2.0, but I'm not familiar enough with whats consider blockers on this project to do that.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)