You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:30:32 UTC
[GitHub] [superset] kgabryje edited a comment on pull request #15117: feat(native-filters): add optional time col to time range
kgabryje edited a comment on pull request #15117:
URL: https://github.com/apache/superset/pull/15117#issuecomment-859597639
A couple of points to discuss:
1. Should the time range picker and time column be in 1 row? That would strongly suggest to the user that those 2 fields are closely related. In my opinion, due to a rather large vertical distance between time range and time column, they seem like separate values at first glance 
2. Should we prefill time column with the default value rather than leaving it empty? That would make it clearer which column is being used, especially when user doesn't know which temporal column is default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org