You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gaston Kleiman <ga...@mesosphere.io> on 2018/05/08 17:21:19 UTC
Re: Review Request 66819: Added FrameworkMetrics struct in framework
struct.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66819/#review202662
-----------------------------------------------------------
src/master/metrics.hpp
Lines 219-221 (patched)
<https://reviews.apache.org/r/66819/#comment284601>
This constructor should be implemented in this patch.
The implementation is introduced in https://reviews.apache.org/r/66820/ with extra parameters.
- Gaston Kleiman
On April 27, 2018, 11:39 a.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66819/
> -----------------------------------------------------------
>
> (Updated April 27, 2018, 11:39 a.m.)
>
>
> Review request for mesos, Benjamin Mahler, Gaston Kleiman, Greg Mann, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added FrameworkMetrics struct in framework struct.
>
>
> Diffs
> -----
>
> src/master/master.hpp 0d9620dd0c232dc1df83477e838eeb7313bf8828
> src/master/metrics.hpp 5699c64bac19cb735a4c72f9a067b1338c2ac3c2
>
>
> Diff: https://reviews.apache.org/r/66819/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Gilbert Song
>
>