You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2021/04/15 14:01:13 UTC

[GitHub] [camel-k] squakez opened a new issue #2223: SourceSpec Type default to empty

squakez opened a new issue #2223:
URL: https://github.com/apache/camel-k/issues/2223


   This is a follow up of [this PR comment](https://github.com/apache/camel-k/pull/2216#issuecomment-820437579). As reported in [camel-k-runtime](https://github.com/apache/camel-k-runtime/issues/658), we may experience some issue because the value of `SourceSpec` type is default to `empty` in several parts of Camel K. We assume that empty value to be a `source` type on the runtime.
   
   Should we enforce the `SourceType` to a value instead? I think it would be cleaner.
   
   cc @lburgazzoli @astefanutti @nicolaferraro 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] lburgazzoli commented on issue #2223: SourceSpec Type default to empty

Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #2223:
URL: https://github.com/apache/camel-k/issues/2223#issuecomment-820447375


   can we set the default value on runtime ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] lburgazzoli closed issue #2223: SourceSpec Type default to empty

Posted by GitBox <gi...@apache.org>.
lburgazzoli closed issue #2223:
URL: https://github.com/apache/camel-k/issues/2223


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] squakez commented on issue #2223: SourceSpec Type default to empty

Posted by GitBox <gi...@apache.org>.
squakez commented on issue #2223:
URL: https://github.com/apache/camel-k/issues/2223#issuecomment-820451983


   > can we set the default value on runtime ?
   
   I think we can. Does that mean that we assume that a default values is always a `source` type?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-k] lburgazzoli commented on issue #2223: SourceSpec Type default to empty

Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on issue #2223:
URL: https://github.com/apache/camel-k/issues/2223#issuecomment-820453716


   I'm fine with that


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org