You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@baremaps.apache.org by "YongGoose (via GitHub)" <gi...@apache.org> on 2025/02/08 05:53:12 UTC

[I] [BUG] When the zoom level is set in `baseMap`, it is automatically converted to an integer. [incubator-baremaps]

YongGoose opened a new issue, #947:
URL: https://github.com/apache/incubator-baremaps/issues/947

   <!-- 
   Briefly describe the issue and expected behavior.  Keep it short but clear to help identify the problem quickly. 
   -->
   ## Description
   If you set `minZoom` or 'maxZoom' to a float value like `2.5`, it will automatically be converted to `2`.
   ```
   {
     minzoom: 2.5,
     maxzoom: 20,
     sql:
       "SELECT id, tags, geom " +
       "FROM osm_boundary " +
       "WHERE tags ->> 'admin_level' = '2' " +
       "AND tags ->> 'maritime' = 'yes';",
   }
   ```
   
   <!-- 
   Specify the environment details where the issue occurred. Helps to determine if the bug is environment-specific. 
   -->
   ## Environment
   - **Browser/Version:** chrome
   - **Version:** 0.8.1
   
   <!-- 
   Describe the difference between the expected and actual outcomes. This helps clarify the impact of the bug. 
   -->
   ## Expected vs Actual Behavior
   - **Expected:** Setting `minZoom` to 2.5 should apply it when the zoom level is `2.5` or higher.
   - **Actual:** However, it actually applies when `minZoom` is `2.0` or higher.
   
   <!-- 
   (Optional) Add supporting materials like screenshots or logs to provide more context about the issue. 
   -->
   ## Attachments (Optional)
   Maritime boundaries should be applied from zoom level `2.5` and above, but they can be seen applying from `2.0`.
   ![Image](https://github.com/user-attachments/assets/e2bbf3ae-aca2-4a49-932a-367bb0d3cc26)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [BUG] When the zoom level is set in `baseMap`, it is automatically converted to an integer. [incubator-baremaps]

Posted by "YongGoose (via GitHub)" <gi...@apache.org>.
YongGoose commented on issue #947:
URL: https://github.com/apache/incubator-baremaps/issues/947#issuecomment-2644524983

   If this is a bug, it could be a sub-issue of the below issue.
   - https://github.com/apache/incubator-baremaps/issues/927


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [BUG] When the zoom level is set in `baseMap`, it is automatically converted to an integer. [incubator-baremaps]

Posted by "YongGoose (via GitHub)" <gi...@apache.org>.
YongGoose commented on issue #947:
URL: https://github.com/apache/incubator-baremaps/issues/947#issuecomment-2645238215

   > I believe the java object uses an integer instead of a double for the zoom level. We can indeed change this as it better corresponds to the maplibre style specification.
   
   I believe these two classes are definitely related!
   - https://github.com/apache/incubator-baremaps/blob/28e5bb4b9d1693d297dc849074b9126dd392ce4d/baremaps-maplibre/src/main/java/org/apache/baremaps/maplibre/style/StyleSource.java#L43
   - https://github.com/apache/incubator-baremaps/blob/28e5bb4b9d1693d297dc849074b9126dd392ce4d/baremaps-maplibre/src/main/java/org/apache/baremaps/maplibre/style/StyleLayer.java#L53
   
   If this issue is not resolved by next week, I will take care of it myself.
   
   PS. I am not a member of the Apache Baremaps repository, so I don't have the permissions to register this as a sub-issue. Would you mind handling this? 😅
   
   I think it would be appropriate for these two issues to be registered as sub-issues of the #927.
   - https://github.com/apache/incubator-baremaps/issues/947
   - https://github.com/apache/incubator-baremaps/issues/949


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [BUG] When the zoom level is set in `baseMap`, it is automatically converted to an integer. [incubator-baremaps]

Posted by "bchapuis (via GitHub)" <gi...@apache.org>.
bchapuis commented on issue #947:
URL: https://github.com/apache/incubator-baremaps/issues/947#issuecomment-2645031015

   I believe the java object uses an integer instead of a double for the zoom level. We can indeed change this as it better corresponds to the maplibre style specification.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [BUG] When the zoom level is set in `baseMap`, it is automatically converted to an integer. [incubator-baremaps]

Posted by "bchapuis (via GitHub)" <gi...@apache.org>.
bchapuis commented on issue #947:
URL: https://github.com/apache/incubator-baremaps/issues/947#issuecomment-2645336211

   Thanks for the clarification. I attached it as a sub issue of #927.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@baremaps.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org