Re: [PR] Replace deprecated search(Query, Collector) with CollectorManager in JoinUtil [lucene]

["javanna (via GitHub)" <gi...@apache.org>]

javanna commented on code in PR #16091:
URL: https://github.com/apache/lucene/pull/16091#discussion_r3776068225


##########
lucene/join/src/java/org/apache/lucene/search/join/JoinUtil.java:
##########
@@ -550,11 +554,26 @@ public static Query createJoinQuery(
         break;
       case None:
         if (min <= 1 && max == Integer.MAX_VALUE) {
-          GlobalOrdinalsCollector globalOrdinalsCollector =
-              new GlobalOrdinalsCollector(joinField, ordinalMap, valueCount);
-          searcher.search(rewrittenFromQuery, globalOrdinalsCollector);
+          LongBitSet collectedOrds =
+              searcher.search(
+                  rewrittenFromQuery,
+                  new CollectorManager<GlobalOrdinalsCollector, LongBitSet>() {
+                    @Override
+                    public GlobalOrdinalsCollector newCollector() {
+                      return new GlobalOrdinalsCollector(joinField, finalOrdinalMap, valueCount);
+                    }

Review Comment:
   I pushed a different version that is much closer to what the original collector did, and added a collector manager on top of it. The memory concerns should addressed by that. I am going to resolve this thread and will request another review round.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org