[jira] [Commented] (NIFI-5150) ProcessSession.append resulting in content from wrong FlowFile

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-5150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16464062#comment-16464062 ] 

ASF GitHub Bot commented on NIFI-5150:
--------------------------------------

GitHub user markap14 opened a pull request:

    https://github.com/apache/nifi/pull/2676

    NIFI-5150: Fixed bug that caused StandardProcessSession.append() to c…

    …opy too much data when called on an incoming flowfile
    
    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markap14/nifi NIFI-5150

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2676.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2676
    
----
commit fe00fd994627b5294d65c138b7c303f959df41c3
Author: Mark Payne <ma...@...>
Date:   2018-05-04T16:03:14Z

    NIFI-5150: Fixed bug that caused StandardProcessSession.append() to copy too much data when called on an incoming flowfile

----


> ProcessSession.append resulting in content from wrong FlowFile
> --------------------------------------------------------------
>
>                 Key: NIFI-5150
>                 URL: https://issues.apache.org/jira/browse/NIFI-5150
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>    Affects Versions: 1.5.0, 1.6.0
>            Reporter: Peter Radden
>            Priority: Major
>
> Consider the following two processors with these simple implementations:
> Processor1:
> {quote}
> {code:java}
> FlowFile ffa = session.create();
> ffa = session.write(ffa, (out) -> out.write('A'));
> session.transfer(ffa, REL_SUCCESS);
> FlowFile ffb = session.create();
> ffb = session.write(ffb, (out) -> out.write('B'));
> session.transfer(ffb, REL_SUCCESS);{code}
> {quote}
> Processor2:
> {quote}
> {code:java}
> FlowFile ff = session.get();
> ff = session.append(ff, (out) -> out.write('C'));
> session.transfer(ff, REL_SUCCESS);{code}
> {quote}
> Processor2 is connected to the Success relationship of Processor1.
> After Processor1 has been triggered, the connecting queue should have two FlowFiles with content "A" and "B".  This is correct, and they seem to have the same Content Claim identifier with offsets 1 byte apart, and size also 1 byte.
> After Processor2, the expected contents are "AC" and "BC".
> In fact, both flowfiles are 3 bytes in size with contents "ABC".
> This suggests that the claim offset and size are not applied correctly when using ProcessSession.append.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)