You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/02/14 13:12:33 UTC

[GitHub] [hive] aasha opened a new pull request #913: HIVE-22890 Fix replication of tables with _functions in the tablename

aasha opened a new pull request #913: HIVE-22890 Fix replication of tables with _functions in the tablename
URL: https://github.com/apache/hive/pull/913
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] aasha commented on a change in pull request #913: HIVE-22890 Fix replication of tables with _functions in the tablename

Posted by GitBox <gi...@apache.org>.
aasha commented on a change in pull request #913: HIVE-22890 Fix replication of tables with _functions in the tablename
URL: https://github.com/apache/hive/pull/913#discussion_r379900416
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/events/filesystem/DatabaseEventsIterator.java
 ##########
 @@ -170,7 +170,7 @@ public BootstrapEvent next() {
     }
 
     String currentPath = next.toString();
-    if (currentPath.contains(FUNCTIONS_ROOT_DIR_NAME)) {
+    if (currentPath.contains(Path.SEPARATOR + FUNCTIONS_ROOT_DIR_NAME)) {
 
 Review comment:
   I have added it both before and after now. However we are not allowed to create tables starting with underscrore (like _functions_t1), gives a parse exception.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] maheshk114 commented on a change in pull request #913: HIVE-22890 Fix replication of tables with _functions in the tablename

Posted by GitBox <gi...@apache.org>.
maheshk114 commented on a change in pull request #913: HIVE-22890 Fix replication of tables with _functions in the tablename
URL: https://github.com/apache/hive/pull/913#discussion_r379896300
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/events/filesystem/DatabaseEventsIterator.java
 ##########
 @@ -170,7 +170,7 @@ public BootstrapEvent next() {
     }
 
     String currentPath = next.toString();
-    if (currentPath.contains(FUNCTIONS_ROOT_DIR_NAME)) {
+    if (currentPath.contains(Path.SEPARATOR + FUNCTIONS_ROOT_DIR_NAME)) {
 
 Review comment:
   better to append Path.SEPARATOR after _functions for check

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org

[GitHub] [hive] aasha commented on a change in pull request #913: HIVE-22890 Fix replication of tables with _functions in the tablename

Posted by GitBox <gi...@apache.org>.
aasha commented on a change in pull request #913: HIVE-22890 Fix replication of tables with _functions in the tablename
URL: https://github.com/apache/hive/pull/913#discussion_r379900416
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/bootstrap/events/filesystem/DatabaseEventsIterator.java
 ##########
 @@ -170,7 +170,7 @@ public BootstrapEvent next() {
     }
 
     String currentPath = next.toString();
-    if (currentPath.contains(FUNCTIONS_ROOT_DIR_NAME)) {
+    if (currentPath.contains(Path.SEPARATOR + FUNCTIONS_ROOT_DIR_NAME)) {
 
 Review comment:
   I have added it both before and after now. However we are not allowed to create tables starting with _ in hive (like _functions_t1), gives a parse exception.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org