You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/13 13:34:14 UTC

[GitHub] [airflow] Voldurk opened a new pull request, #27033: DataflowStopJobOperator Operator

Voldurk opened a new pull request, #27033:
URL: https://github.com/apache/airflow/pull/27033

   - _wait_for_states() fix
   - _get_current_jobs() and cancel() adjustment to allow stopping multiple jobs by name
   - New operator:  DataflowStopJobOperator
   - Removed batch request from cancel() method as it was not working for  gogleapis.dataflow.v1b3.projects.locations.jobs.update
   
   
   
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #27033: DataflowStopJobOperator Operator

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #27033:
URL: https://github.com/apache/airflow/pull/27033#issuecomment-1288131100

   Looks good, but could you please make a Howto example (see howto_operator_start_template_job as example on how you can do it - look in the documentation for google providers. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk merged pull request #27033: DataflowStopJobOperator Operator

Posted by GitBox <gi...@apache.org>.
potiuk merged PR #27033:
URL: https://github.com/apache/airflow/pull/27033


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] Voldurk commented on pull request #27033: DataflowStopJobOperator Operator

Posted by GitBox <gi...@apache.org>.
Voldurk commented on PR #27033:
URL: https://github.com/apache/airflow/pull/27033#issuecomment-1295283193

   @potiuk Updated. Not sure what I can do about that 'unhealthy container' on sql server test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #27033: DataflowStopJobOperator Operator

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #27033:
URL: https://github.com/apache/airflow/pull/27033#issuecomment-1296552188

   Ignore (for now - this is on our flaky-list-to-solve)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org