You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/12/17 02:32:45 UTC

[GitHub] [pulsar] tisonkun commented on a diff in pull request #18961: [improve][doc] Update PR template and PIP for metrics changes

tisonkun commented on code in PR #18961:
URL: https://github.com/apache/pulsar/pull/18961#discussion_r1051293235


##########
.github/PULL_REQUEST_TEMPLATE.md:
##########
@@ -60,8 +66,11 @@ This change added tests and can be verified as follows:
 - [ ] The binary protocol
 - [ ] The REST endpoints
 - [ ] The admin CLI options
+- [ ] The metrics
 - [ ] Anything that affects deployment
 
+<!-- NOTE: A PIP is required if the PR will change any parts of the above. See https://github.com/apache/pulsar/blob/master/wiki/proposals/PIP.md -->

Review Comment:
   This statement is not true: change dependency doesn't always require a PIP.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org