You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/08 16:42:44 UTC
[GitHub] [spark] bfallik opened a new pull request #35774: fix minor typos
bfallik opened a new pull request #35774:
URL: https://github.com/apache/spark/pull/35774
I'm just learning Spark but am assuming that these code examples refer to the `RESPECT NULLS` syntax called out just below.
### What changes were proposed in this pull request?
fix a basic typo
### Why are the changes needed?
RESECT isn't a valid term here
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
inspect via Github UI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic edited a comment on pull request #35774: fix minor typos
Posted by GitBox <gi...@apache.org>.
itholic edited a comment on pull request #35774:
URL: https://github.com/apache/spark/pull/35774#issuecomment-1063673051
Can you create a related [Apache Spark JIRA](https://issues.apache.org/jira/projects/SPARK/summary) and fix the title ??
Also I think we can move "I'm just learning Spark but am assuming that these code examples refer to the RESPECT NULLS syntax called out just below." to under "Why are the changes needed?" or just remove this.
You can refer to https://spark.apache.org/contributing.html and other PRs for more detailed reference :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] bfallik commented on pull request #35774: fix minor typos
Posted by GitBox <gi...@apache.org>.
bfallik commented on pull request #35774:
URL: https://github.com/apache/spark/pull/35774#issuecomment-1063641425
@itholic looks like the tests all pass now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic edited a comment on pull request #35774: fix minor typos
Posted by GitBox <gi...@apache.org>.
itholic edited a comment on pull request #35774:
URL: https://github.com/apache/spark/pull/35774#issuecomment-1063673051
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] bfallik commented on pull request #35774: fix minor typos
Posted by GitBox <gi...@apache.org>.
bfallik commented on pull request #35774:
URL: https://github.com/apache/spark/pull/35774#issuecomment-1064169342
Hi @itholic ,
Please know that I appreciate all the hard work, often thankless, that project committers undertake to try and manage community activity into a sensible workflow, but this is starting to feel like a lot of back-and-forth for a documentation change to correct an obvious misspelling.
I did review the contribution guidelines before posting this PR. The section on "Contributing documentation changes" says
> To propose a change to release documentation (that is, docs that appear under https://spark.apache.org/docs/), edit the Markdown source files in Spark’s [docs/](https://github.com/apache/spark/tree/master/docs) directory, whose README file shows how to build the documentation locally to test your changes. The process to propose a doc change is otherwise the same as the process for proposing code changes below.
and, notably, the section on "Contributing code changes" says
> 2. If the change is new, then it usually needs a new JIRA. However, trivial changes, where the what should change is virtually the same as the how it should change do not require a JIRA. Example: Fix typos in Foo scaladoc
I read that example and assumed this trivial change didn't need a JIRA ticket.
I'll go ahead and edit the description to address your most recent suggestion. Appreciate your help getting the automated checks to pass.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #35774: [MINOR][DOCS] Fix minor typos at nulls_option in Window Functions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #35774:
URL: https://github.com/apache/spark/pull/35774#issuecomment-1064651398
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #35774: fix minor typos
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #35774:
URL: https://github.com/apache/spark/pull/35774#issuecomment-1063595557
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic edited a comment on pull request #35774: fix minor typos
Posted by GitBox <gi...@apache.org>.
itholic edited a comment on pull request #35774:
URL: https://github.com/apache/spark/pull/35774#issuecomment-1063420778
Could you make the test pass by allowing Github Actions in your forked repository ??
Please refer to https://github.com/apache/spark/pull/35774/checks?check_run_id=5467958735.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic edited a comment on pull request #35774: fix minor typos
Posted by GitBox <gi...@apache.org>.
itholic edited a comment on pull request #35774:
URL: https://github.com/apache/spark/pull/35774#issuecomment-1063673051
Great! BTW, also we should follow the [contribution guideline ](https://spark.apache.org/contributing.html)from community.
Can you create a related [Apache Spark JIRA](https://issues.apache.org/jira/projects/SPARK/summary) and fix the title ??
Also I think we can move "I'm just learning Spark but am assuming that these code examples refer to the RESPECT NULLS syntax called out just below." to under "Why are the changes needed?" or just remove this.
You can also refer to other PRs as reference :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #35774: fix minor typos
Posted by GitBox <gi...@apache.org>.
itholic commented on pull request #35774:
URL: https://github.com/apache/spark/pull/35774#issuecomment-1063673051
Can you create a related JIRA and fix the title ??
Also I think we can move "I'm just learning Spark but am assuming that these code examples refer to the RESPECT NULLS syntax called out just below." to under "Why are the changes needed?" or just remove this.
You can refer to https://spark.apache.org/contributing.html and other PRs for more detailed reference :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic edited a comment on pull request #35774: fix minor typos
Posted by GitBox <gi...@apache.org>.
itholic edited a comment on pull request #35774:
URL: https://github.com/apache/spark/pull/35774#issuecomment-1063673051
Great! BTW, also we should follow the guide from community.
Can you create a related [Apache Spark JIRA](https://issues.apache.org/jira/projects/SPARK/summary) and fix the title ??
Also I think we can move "I'm just learning Spark but am assuming that these code examples refer to the RESPECT NULLS syntax called out just below." to under "Why are the changes needed?" or just remove this.
You can refer to https://spark.apache.org/contributing.html and other PRs for more detailed reference :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #35774: fix minor typos
Posted by GitBox <gi...@apache.org>.
itholic commented on pull request #35774:
URL: https://github.com/apache/spark/pull/35774#issuecomment-1064537263
cc @HyukjinKwon I think maybe we could just merge this trivial patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #35774: fix minor typos
Posted by GitBox <gi...@apache.org>.
itholic commented on pull request #35774:
URL: https://github.com/apache/spark/pull/35774#issuecomment-1064536256
@bfallik That makes sense to me. Thanks for the update description!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #35774: [MINOR][DOCS] Fix minor typos at nulls_option in Window Functions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #35774:
URL: https://github.com/apache/spark/pull/35774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #35774: fix minor typos
Posted by GitBox <gi...@apache.org>.
itholic commented on pull request #35774:
URL: https://github.com/apache/spark/pull/35774#issuecomment-1063565783
Here is an example:
1. Click the "Details" on the failed test (`Build and test` for your case)
<img width="762" alt="Screen Shot 2022-03-10 at 10 35 17 AM" src="https://user-images.githubusercontent.com/44108233/157569767-b6e89d6f-b13f-4f3d-a70c-41dd1c1263a0.png">
2. Click the "See test results" on the right side.
<img width="555" alt="Screen Shot 2022-03-10 at 10 34 21 AM" src="https://user-images.githubusercontent.com/44108233/157569680-9d850287-0710-492e-887a-a9a7952a1b10.png">
3. Click the "Re-run all jobs" on the right-above side, then now you can re-run the tests.
<img width="572" alt="Screen Shot 2022-03-10 at 10 35 52 AM" src="https://user-images.githubusercontent.com/44108233/157569833-eca2f58c-69c4-452c-bd48-f36a8836f690.png">
**Or, you can just push the empty commit to re-trigger the test via `git commit --allow-empty` command**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic edited a comment on pull request #35774: fix minor typos
Posted by GitBox <gi...@apache.org>.
itholic edited a comment on pull request #35774:
URL: https://github.com/apache/spark/pull/35774#issuecomment-1063673051
Can you create a related [Apache Spark JIRA](https://issues.apache.org/jira/projects/SPARK/summary) and fix the title ??
Also I think we can move "I'm just learning Spark but am assuming that these code examples refer to the RESPECT NULLS syntax called out just below." to under "Why are the changes needed?" or just remove this.
We should follow the guide from community.
You can refer to https://spark.apache.org/contributing.html and other PRs for more detailed reference :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic edited a comment on pull request #35774: fix minor typos
Posted by GitBox <gi...@apache.org>.
itholic edited a comment on pull request #35774:
URL: https://github.com/apache/spark/pull/35774#issuecomment-1063565783
Here is an example:
1. Click the "Details" on the failed test (`Build and test` for your case)
<img width="762" alt="Screen Shot 2022-03-10 at 10 35 17 AM" src="https://user-images.githubusercontent.com/44108233/157569767-b6e89d6f-b13f-4f3d-a70c-41dd1c1263a0.png">
2. Click the "See test results" on the right side.
<img width="555" alt="Screen Shot 2022-03-10 at 10 34 21 AM" src="https://user-images.githubusercontent.com/44108233/157569680-9d850287-0710-492e-887a-a9a7952a1b10.png">
3. Click the "Re-run all jobs" on the right-above side, then now you can rerun the tests.
<img width="572" alt="Screen Shot 2022-03-10 at 10 35 52 AM" src="https://user-images.githubusercontent.com/44108233/157569833-eca2f58c-69c4-452c-bd48-f36a8836f690.png">
**Or, you can just push the empty commit to rerun the test via `git commit --allow-empty` command**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #35774: fix minor typos
Posted by GitBox <gi...@apache.org>.
itholic commented on pull request #35774:
URL: https://github.com/apache/spark/pull/35774#issuecomment-1063423071
And for "Does this PR introduce any user-facing change?", I think we have user-facing change since we fix the typo in the documentation which users can read.
So, maybe we can simply say like, "Yes, the typo in documentation is corrected" or something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic commented on pull request #35774: fix minor typos
Posted by GitBox <gi...@apache.org>.
itholic commented on pull request #35774:
URL: https://github.com/apache/spark/pull/35774#issuecomment-1063420778
Could you make the test pass by allowing workflow run for testing the changes in your PR ??
Please refer to https://github.com/apache/spark/pull/35774/checks?check_run_id=5467958735.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] itholic edited a comment on pull request #35774: fix minor typos
Posted by GitBox <gi...@apache.org>.
itholic edited a comment on pull request #35774:
URL: https://github.com/apache/spark/pull/35774#issuecomment-1063420778
Could you make the test pass by allowing workflow run ??
Please refer to https://github.com/apache/spark/pull/35774/checks?check_run_id=5467958735.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] bfallik commented on pull request #35774: fix minor typos
Posted by GitBox <gi...@apache.org>.
bfallik commented on pull request #35774:
URL: https://github.com/apache/spark/pull/35774#issuecomment-1063428300
@itholic after enabling github actions on my private repo, how do I rerun the failed check? I don't see any obvious way to do it within the GH UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org