You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "GUIDINGLI (via GitHub)" <gi...@apache.org> on 2023/08/03 08:00:03 UTC

[GitHub] [nuttx] GUIDINGLI opened a new pull request, #10051: xtensa: fix compile miss file

GUIDINGLI opened a new pull request, #10051:
URL: https://github.com/apache/nuttx/pull/10051

   ## Summary
   
   xtensa: fix compile miss file
   
   ## Impact
   
   xtensa
   
   ## Testing
   
   VELA
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nuttx] xiaoxiang781216 merged pull request #10051: xtensa: fix compile miss file

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #10051:
URL: https://github.com/apache/nuttx/pull/10051


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #10051: xtensa: fix compile miss file

Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #10051:
URL: https://github.com/apache/nuttx/pull/10051#discussion_r1284729631


##########
arch/xtensa/src/common/xtensa_mpu.c:
##########
@@ -136,3 +138,5 @@ void mpu_configure_region(uintptr_t base, size_t size,
 
   xtensa_mpu_base[region] = base;
 }
+
+#endif /* XCHAL_MPU_ENTRIES > 0 */

Review Comment:
   ```suggestion
   #endif /* XCHAL_MPU_ENTRIES > 0 */
   
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #10051: xtensa: fix compile miss file

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #10051:
URL: https://github.com/apache/nuttx/pull/10051#discussion_r1285042014


##########
arch/xtensa/src/common/xtensa_mpu.c:
##########
@@ -136,3 +138,5 @@ void mpu_configure_region(uintptr_t base, size_t size,
 
   xtensa_mpu_base[region] = base;
 }
+
+#endif /* XCHAL_MPU_ENTRIES > 0 */

Review Comment:
   Fix



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org