You are viewing a plain text version of this content. The canonical link for it is here.
Posted to sanselan-dev@incubator.apache.org by "Craig Russell (JIRA)" <ji...@apache.org> on 2007/10/08 00:16:50 UTC
[jira] Commented: (SANSELAN-1) Initial code drop
[ https://issues.apache.org/jira/browse/SANSELAN-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12533012 ]
Craig Russell commented on SANSELAN-1:
--------------------------------------
Just a few comments to get started.
Good to have the Apache license done already.
The structure is fine. Tests can be added to the directory structure parallel to main. Have you thought about unit testing?
What should the svn eol style be for the project? I've used LF and native for different projects, and now use LF because the Windows users I work with mostly use unix tools not Windows tools so they prefer LF.
Formatting seems to use tabs not blanks for indenting. This is a user choice and my recommendation is for four spaces no tabs but this is just a community decision that needs to be made.
So, bottom line:
license: check.
directory structure: check.
eol style and formatting: need to discuss some more.
> Initial code drop
> -----------------
>
> Key: SANSELAN-1
> URL: https://issues.apache.org/jira/browse/SANSELAN-1
> Project: Sanselan
> Issue Type: New Feature
> Reporter: Craig Russell
> Assignee: Carsten Ziegeler
> Attachments: patch_init.zip
>
>
> This issue is to discuss the initial code drop into the project.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Commented: (SANSELAN-1) Initial code drop
Posted by Craig L Russell <Cr...@Sun.COM>.
On Oct 23, 2007, at 7:54 PM, Charles Matthew Chen wrote:
> Can anyone point me to some documentation about Apache's
> policy/guidelines for adding data (such as images) to the repo for
> unit testing purposes?
This is draft policy. http://people.apache.org/~cliffs/3party.html
>
> I've found many public domain images on the net which we could use
> as a starting point for writing unit tests. Is it sufficient for them
> to be in the public domain?
Yes. What we need to do is to put the license text if any into the
NOTICES file identifying the images by file name or directory name.
I'm assuming that the images themselves don't "self identify" since
they're in some binary format.
Craig
>
> See below.
>
> Thanks,
> Charles.
>
>
>> I have a suite of unit tests but they depend on my image library
>> which I do not own the IP rights to. Many were given to me as
>> part of
>> bug reports. I'm going to start working on a new suite of unit
>> tests.
>>
>> What's the policy for adding this kind of data to the repo? Is it
>> sufficient for the image to be in the public domain, or do we need a
>> CLA (or some such) from each image source?
Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:Craig.Russell@sun.com
P.S. A good JDO? O, Gasp!
Re: [jira] Commented: (SANSELAN-1) Initial code drop
Posted by Charles Matthew Chen <ch...@gmail.com>.
Can anyone point me to some documentation about Apache's
policy/guidelines for adding data (such as images) to the repo for
unit testing purposes?
I've found many public domain images on the net which we could use
as a starting point for writing unit tests. Is it sufficient for them
to be in the public domain?
See below.
Thanks,
Charles.
> I have a suite of unit tests but they depend on my image library
> which I do not own the IP rights to. Many were given to me as part of
> bug reports. I'm going to start working on a new suite of unit tests.
>
> What's the policy for adding this kind of data to the repo? Is it
> sufficient for the image to be in the public domain, or do we need a
> CLA (or some such) from each image source?
Re: [jira] Commented: (SANSELAN-1) Initial code drop
Posted by Charles Matthew Chen <ch...@gmail.com>.
> The structure is fine. Tests can be added to the directory structure parallel to main. Have you thought about unit testing?
I have a suite of unit tests but they depend on my image library
which I do not own the IP rights to. Many were given to me as part of
bug reports. I'm going to start working on a new suite of unit tests.
What's the policy for adding this kind of data to the repo? Is it
sufficient for the image to be in the public domain, or do we need a
CLA (or some such) from each image source?
> What should the svn eol style be for the project? I've used LF and native for different projects, and now use LF because the Windows users I work with mostly use unix tools not Windows tools so they prefer LF.
>
> Formatting seems to use tabs not blanks for indenting. This is a user choice and my recommendation is for four spaces no tabs but this is just a community decision that needs to be made.
>
> eol style and formatting: need to discuss some more.
I have no strong opinion about eols & indents.
Charles.