You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Dan Dumont (JIRA)" <ji...@apache.org> on 2012/05/03 16:54:55 UTC
[jira] [Created] (SHINDIG-1766) Inject default style into gadgets
to allow inner content to scroll.
Dan Dumont created SHINDIG-1766:
-----------------------------------
Summary: Inject default style into gadgets to allow inner content to scroll.
Key: SHINDIG-1766
URL: https://issues.apache.org/jira/browse/SHINDIG-1766
Project: Shindig
Issue Type: Improvement
Reporter: Dan Dumont
Assignee: Dan Dumont
There's a conversation on the open social discussion google group, but I can't get the link to place here yet. Will update when I get it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1766) Inject default style into gadgets
to allow inner content to scroll.
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268396#comment-13268396 ]
jiraposter@reviews.apache.org commented on SHINDIG-1766:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4973/#review7558
-----------------------------------------------------------
Ship it!
LGTM
- Ryan
On 2012-05-03 14:54:20, Dan Dumont wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4973/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-03 14:54:20)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. I know this is a small review, but I wanted to be able to link to the review in email threads on the dev and spec lists.
bq.
bq.
bq. This addresses bug SHINDIG-1766.
bq. https://issues.apache.org/jira/browse/SHINDIG-1766
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java 1333049
bq.
bq. Diff: https://reviews.apache.org/r/4973/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. All tests pass.
bq.
bq.
bq. Thanks,
bq.
bq. Dan
bq.
bq.
> Inject default style into gadgets to allow inner content to scroll.
> -------------------------------------------------------------------
>
> Key: SHINDIG-1766
> URL: https://issues.apache.org/jira/browse/SHINDIG-1766
> Project: Shindig
> Issue Type: Improvement
> Reporter: Dan Dumont
> Assignee: Dan Dumont
>
> There's a conversation on the open social discussion google group, but I can't get the link to place here yet. Will update when I get it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SHINDIG-1766) Inject default style into gadgets
to allow inner content to scroll.
Posted by "Dan Dumont (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Dumont resolved SHINDIG-1766.
---------------------------------
Resolution: Fixed
Committed r1333997
> Inject default style into gadgets to allow inner content to scroll.
> -------------------------------------------------------------------
>
> Key: SHINDIG-1766
> URL: https://issues.apache.org/jira/browse/SHINDIG-1766
> Project: Shindig
> Issue Type: Improvement
> Reporter: Dan Dumont
> Assignee: Dan Dumont
> Attachments: shindig.patch
>
>
> There's a conversation on the open social discussion google group, but I can't get the link to place here yet. Will update when I get it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1766) Inject default style into gadgets
to allow inner content to scroll.
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13267482#comment-13267482 ]
jiraposter@reviews.apache.org commented on SHINDIG-1766:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4973/
-----------------------------------------------------------
(Updated 2012-05-03 14:54:20.611954)
Review request for shindig.
Changes
-------
Adding JIRA
Summary
-------
I know this is a small review, but I wanted to be able to link to the review in email threads on the dev and spec lists.
This addresses bug SHINDIG-1766.
https://issues.apache.org/jira/browse/SHINDIG-1766
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java 1333049
Diff: https://reviews.apache.org/r/4973/diff
Testing
-------
All tests pass.
Thanks,
Dan
> Inject default style into gadgets to allow inner content to scroll.
> -------------------------------------------------------------------
>
> Key: SHINDIG-1766
> URL: https://issues.apache.org/jira/browse/SHINDIG-1766
> Project: Shindig
> Issue Type: Improvement
> Reporter: Dan Dumont
> Assignee: Dan Dumont
>
> There's a conversation on the open social discussion google group, but I can't get the link to place here yet. Will update when I get it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1766) Inject default style into gadgets
to allow inner content to scroll.
Posted by "Ryan Baxter (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan Baxter updated SHINDIG-1766:
---------------------------------
Fix Version/s: 2.5.0-beta2
> Inject default style into gadgets to allow inner content to scroll.
> -------------------------------------------------------------------
>
> Key: SHINDIG-1766
> URL: https://issues.apache.org/jira/browse/SHINDIG-1766
> Project: Shindig
> Issue Type: Improvement
> Reporter: Dan Dumont
> Assignee: Dan Dumont
> Fix For: 2.5.0-beta2
>
> Attachments: shindig.patch
>
>
> There's a conversation on the open social discussion google group, but I can't get the link to place here yet. Will update when I get it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1766) Inject default style into gadgets
to allow inner content to scroll.
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13268409#comment-13268409 ]
jiraposter@reviews.apache.org commented on SHINDIG-1766:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4973/#review7560
-----------------------------------------------------------
Ship it!
Committed r1333997
- Dan
On 2012-05-03 14:54:20, Dan Dumont wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4973/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-03 14:54:20)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. I know this is a small review, but I wanted to be able to link to the review in email threads on the dev and spec lists.
bq.
bq.
bq. This addresses bug SHINDIG-1766.
bq. https://issues.apache.org/jira/browse/SHINDIG-1766
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java 1333049
bq.
bq. Diff: https://reviews.apache.org/r/4973/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. All tests pass.
bq.
bq.
bq. Thanks,
bq.
bq. Dan
bq.
bq.
> Inject default style into gadgets to allow inner content to scroll.
> -------------------------------------------------------------------
>
> Key: SHINDIG-1766
> URL: https://issues.apache.org/jira/browse/SHINDIG-1766
> Project: Shindig
> Issue Type: Improvement
> Reporter: Dan Dumont
> Assignee: Dan Dumont
> Attachments: shindig.patch
>
>
> There's a conversation on the open social discussion google group, but I can't get the link to place here yet. Will update when I get it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1766) Inject default style into gadgets
to allow inner content to scroll.
Posted by "Dan Dumont (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Dan Dumont updated SHINDIG-1766:
--------------------------------
Attachment: shindig.patch
> Inject default style into gadgets to allow inner content to scroll.
> -------------------------------------------------------------------
>
> Key: SHINDIG-1766
> URL: https://issues.apache.org/jira/browse/SHINDIG-1766
> Project: Shindig
> Issue Type: Improvement
> Reporter: Dan Dumont
> Assignee: Dan Dumont
> Attachments: shindig.patch
>
>
> There's a conversation on the open social discussion google group, but I can't get the link to place here yet. Will update when I get it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira