You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/10/17 02:59:49 UTC

[GitHub] [incubator-kyuubi] deadwind4 opened a new pull request, #3642: [KYUUBI #3611][DOCS] Add session resource REST docs

deadwind4 opened a new pull request, #3642:
URL: https://github.com/apache/incubator-kyuubi/pull/3642

   ### _Why are the changes needed?_
   Add session resource REST docs in `rest_api.md`
   
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3642: [KYUUBI #3611][DOCS] Add session resource REST docs

Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3642:
URL: https://github.com/apache/incubator-kyuubi/pull/3642#discussion_r997155391


##########
docs/client/rest/rest_api.md:
##########
@@ -19,6 +19,248 @@
 
 Note that: now the api version is v1 and the base uri is `/api/v1`.
 
+## Session Resource
+
+### GET /sessions
+
+Get the list of all live sessions
+
+#### Response Body
+
+| Name       | Description                                              | Type   |
+|:-----------|:---------------------------------------------------------|:-------|
+| identifier | The session identifier                                   | String |
+| user       | The user name that created the session                   | String |
+| ipAddr     | The user name that created the batch                     | String |

Review Comment:
   wrong description



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3642: [KYUUBI #3611][DOCS] Add session resource REST docs

Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3642:
URL: https://github.com/apache/incubator-kyuubi/pull/3642#discussion_r997156778


##########
docs/client/rest/rest_api.md:
##########
@@ -19,6 +19,248 @@
 
 Note that: now the api version is v1 and the base uri is `/api/v1`.
 
+## Session Resource
+
+### GET /sessions
+
+Get the list of all live sessions
+
+#### Response Body
+
+| Name       | Description                                              | Type   |
+|:-----------|:---------------------------------------------------------|:-------|
+| identifier | The session identifier                                   | String |
+| user       | The user name that created the session                   | String |
+| ipAddr     | The user name that created the batch                     | String |
+| conf       | The configuration of the session                         | Map    |
+| createTime | The session that created after this timestamp            | Long   |

Review Comment:
   after ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3642: [KYUUBI #3611][DOCS] Add session resource REST docs

Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #3642:
URL: https://github.com/apache/incubator-kyuubi/pull/3642#discussion_r997158172


##########
docs/client/rest/rest_api.md:
##########
@@ -19,6 +19,248 @@
 
 Note that: now the api version is v1 and the base uri is `/api/v1`.
 
+## Session Resource
+
+### GET /sessions
+
+Get the list of all live sessions
+
+#### Response Body
+
+| Name       | Description                                              | Type   |
+|:-----------|:---------------------------------------------------------|:-------|
+| identifier | The session identifier                                   | String |
+| user       | The user name that created the session                   | String |
+| ipAddr     | The user name that created the batch                     | String |
+| conf       | The configuration of the session                         | Map    |
+| createTime | The session that created after this timestamp            | Long   |
+| duration   | The interval that last access time subtract created time | Long   |
+| idleTime   | The interval of no operation                             | Long   |
+
+### GET /sessions/${sessionHandle}
+
+Get a session event
+
+#### Response Body
+
+The [KyuubiSessionEvent](#kyuubisessionevent).
+
+### GET /sessions/${sessionHandle}/info/${infoType}
+
+Get an information detail of a session
+
+#### Request Parameters
+
+| Name     | Description                          | Type |
+|:---------|:-------------------------------------|:-----|
+| infoType | The type of Hive Thrift getting info | Int  |

Review Comment:
   Id of Hive Thrift GetInfo



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] pan3793 closed pull request #3642: [KYUUBI #3611][DOCS] Add session resource REST docs

Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #3642: [KYUUBI #3611][DOCS] Add session resource REST docs
URL: https://github.com/apache/incubator-kyuubi/pull/3642


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #3642: [KYUUBI #3611][DOCS] Add session resource REST docs

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3642:
URL: https://github.com/apache/incubator-kyuubi/pull/3642#issuecomment-1281752269

   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/3642?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3642](https://codecov.io/gh/apache/incubator-kyuubi/pull/3642?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3d8e5e6) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/26b78f5c1fb02b9e6bdce96b633bacddb43c229f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (26b78f5) will **increase** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3642      +/-   ##
   ============================================
   + Coverage     51.88%   51.90%   +0.02%     
     Complexity       13       13              
   ============================================
     Files           484      484              
     Lines         27074    27122      +48     
     Branches       3782     3784       +2     
   ============================================
   + Hits          14046    14079      +33     
   - Misses        11663    11674      +11     
   - Partials       1365     1369       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/3642?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../kyuubi/server/mysql/constant/MySQLErrorCode.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3642/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvbXlzcWwvY29uc3RhbnQvTXlTUUxFcnJvckNvZGUuc2NhbGE=) | `13.84% <0.00%> (-6.16%)` | :arrow_down: |
   | [...ache/kyuubi/server/mysql/MySQLCommandHandler.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3642/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvbXlzcWwvTXlTUUxDb21tYW5kSGFuZGxlci5zY2FsYQ==) | `75.00% <0.00%> (-4.55%)` | :arrow_down: |
   | [...ache/kyuubi/server/mysql/MySQLGenericPackets.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3642/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvbXlzcWwvTXlTUUxHZW5lcmljUGFja2V0cy5zY2FsYQ==) | `76.59% <0.00%> (-2.13%)` | :arrow_down: |
   | [...rg/apache/kyuubi/ctl/cmd/log/LogBatchCommand.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3642/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWN0bC9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jdGwvY21kL2xvZy9Mb2dCYXRjaENvbW1hbmQuc2NhbGE=) | `78.00% <0.00%> (-2.00%)` | :arrow_down: |
   | [...src/main/scala/org/apache/spark/ui/EngineTab.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3642/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3BhcmsvdWkvRW5naW5lVGFiLnNjYWxh) | `68.75% <0.00%> (-1.99%)` | :arrow_down: |
   | [...rg/apache/kyuubi/server/api/v1/AdminResource.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3642/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvYXBpL3YxL0FkbWluUmVzb3VyY2Uuc2NhbGE=) | `89.74% <0.00%> (-1.17%)` | :arrow_down: |
   | [...in/scala/org/apache/kyuubi/sql/KyuubiSQLConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3642/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZW5zaW9ucy9zcGFyay9reXV1YmktZXh0ZW5zaW9uLXNwYXJrLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zcWwvS3l1dWJpU1FMQ29uZi5zY2FsYQ==) | `99.01% <0.00%> (-0.99%)` | :arrow_down: |
   | [...yuubi/server/metadata/jdbc/JDBCMetadataStore.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3642/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvbWV0YWRhdGEvamRiYy9KREJDTWV0YWRhdGFTdG9yZS5zY2FsYQ==) | `89.27% <0.00%> (-0.70%)` | :arrow_down: |
   | [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3642/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `97.26% <0.00%> (-0.08%)` | :arrow_down: |
   | [...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3642/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvUHJvY0J1aWxkZXIuc2NhbGE=) | `81.36% <0.00%> (+0.62%)` | :arrow_up: |
   | ... and [2 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/3642/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org

[GitHub] [incubator-kyuubi] pan3793 commented on pull request #3642: [KYUUBI #3611][DOCS] Add session resource REST docs

Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #3642:
URL: https://github.com/apache/incubator-kyuubi/pull/3642#issuecomment-1282659960

   Thanks, merging to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org