You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/17 10:02:28 UTC
[GitHub] [flink] wuchong commented on a change in pull request #11080:
[FLINK-15988][json] Make JsonRowSerializationSchema's constructor private
wuchong commented on a change in pull request #11080: [FLINK-15988][json] Make JsonRowSerializationSchema's constructor private
URL: https://github.com/apache/flink/pull/11080#discussion_r380085386
##########
File path: flink-formats/flink-json/src/main/java/org/apache/flink/formats/json/JsonRowSerializationSchema.java
##########
@@ -99,35 +94,66 @@ public JsonRowSerializationSchema(TypeInformation<Row> typeInfo) {
@PublicEvolving
public static class Builder {
- private final RowTypeInfo typeInfo;
+ private RowTypeInfo typeInfo;
+
+ private Builder() {
+ // private constructor
+ }
/**
+ * @deprecated Use {@link JsonRowSerializationSchema#builder()} instead.
Review comment:
Put the `@deprecated` comment after `@param`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services