You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/05/15 05:57:36 UTC

[GitHub] [fineract] ptuomola opened a new pull request #890: FINERACT-874: Removing files related to old release process

ptuomola opened a new pull request #890:
URL: https://github.com/apache/fineract/pull/890


   ## Description
   Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket
   
   ## Checklist
   Please make sure these boxes are checked before submitting your pull request - thanks!
   
   - [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
   
   - [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
   
   - [ ] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes.
   
   - [ ] Integration tests have been created/updated for verifying the changes made.
   
   - [ ] All Integrations tests are passing with the new commits.
   
   - [ ] Submission is not a "code dump".  (Large changes can be made "in repository" via a branch.  Ask on the list.)
   
   Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] vorburger commented on pull request #890: FINERACT-874: Removing files related to old release process

Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #890:
URL: https://github.com/apache/fineract/pull/890#issuecomment-632014490


   We should tie this together with https://github.com/apache/fineract/#releasing and from there linked https://cwiki.apache.org/confluence/display/FINERACT/How+to+Release+Apache+Fineract and (much too subtly...) https://cwiki.apache.org/confluence/display/FINERACT/Release+Sign ...
   
   I would have assumed that documentation to refer to and suggest using e.g. `./gradlew dist`, but to my surprise, have noticed that they actually do not (it currently documents a surprisingly manual process). This PR therefore gets LGTM from me, as a hopefully first step towards FINERACT-876 for FINERACT-873.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [fineract] awasum merged pull request #890: FINERACT-874: Removing files related to old release process

Posted by GitBox <gi...@apache.org>.
awasum merged pull request #890:
URL: https://github.com/apache/fineract/pull/890


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org