You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/05/14 08:55:33 UTC

[GitHub] xinyu-intel commented on issue #10933: remove unnecessary checks on convolution parameters

xinyu-intel commented on issue #10933: remove unnecessary checks on convolution parameters
URL: https://github.com/apache/incubator-mxnet/pull/10933#issuecomment-388745011
 
 
   According to https://github.com/apache/incubator-mxnet/blob/master/src/operator/nn/convolution.cc#L359, the dilate of 2-D conv has been set hard to `(1,1)`. So `CHECK_GE(param.dilate.ndim(), 2U)` must be passed and `param.dilate.ndim()` can't be `0`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services