You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2015/06/30 15:44:04 UTC

[Bug 58085] New: remove sheet changes sheet reference in formula

https://bz.apache.org/bugzilla/show_bug.cgi?id=58085

            Bug ID: 58085
           Summary: remove sheet changes sheet reference in formula
           Product: POI
           Version: 3.13-dev
          Hardware: PC
            Status: NEW
          Severity: critical
          Priority: P2
         Component: HSSF
          Assignee: dev@poi.apache.org
          Reporter: Yulei.Li@ericsson.com

Created attachment 32864
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=32864&action=edit
handling ExternalSheetRecord when removing sheet

We have xls file that defines many Name references, after calling
removeSheetAt(), and save the workbook to a new file. Open the file in Excel,
go to Formulas->Name Manager, some Names' reference sheet name got changed.

The issue exists in 3.11.Final, 3.12.Final and trunk.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 58085] remove sheet changes sheet reference in formula

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58085

yli <Yu...@ericsson.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32864|0                           |1
           is patch|                            |
  Attachment #32864|application/x-gzip          |text/plain
          mime type|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 58085] [patch]remove sheet changes non-removed sheet references in formula

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58085

Dominik Stadler <do...@gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #3 from Dominik Stadler <do...@gmx.at> ---
The patch is applied via r1710193, thanks a lot for the patch!

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 58085] [patch]remove sheet changes non-removed sheet references in formula

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58085

Dominik Stadler <do...@gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32889|text/plain                  |application/binary
          mime type|                            |
  Attachment #32889|1                           |0
           is patch|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 58085] [patch]remove sheet changes non-removed sheet references in formula

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58085

Dominik Stadler <do...@gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32864|0                           |1
        is obsolete|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 58085] remove sheet changes sheet reference in formula

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58085

--- Comment #1 from yli <Yu...@ericsson.com> ---
Created attachment 32865
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=32865&action=edit
test class to illustrate the issue

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 58085] [patch]remove sheet changes non-removed sheet references in formula

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58085

Dominik Stadler <do...@gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32864|text/plain                  |application/binary
          mime type|                            |
  Attachment #32864|1                           |0
           is patch|                            |

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 58085] [patch]remove sheet changes non-removed sheet references in formula

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58085

--- Comment #2 from yli <Yu...@ericsson.com> ---
Created attachment 32889
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=32889&action=edit
check null pointer for linkTable when no name references defined

recreated patch with extra check for null pointer

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 58085] [patch]remove sheet changes non-removed sheet references in formula

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58085

yli <Yu...@ericsson.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[patch]remove sheet changes |[patch]remove sheet changes
                   |sheet reference in formula  |non-removed sheet
                   |                            |references in formula

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 58085] [patch]remove sheet changes non-removed sheet references in formula

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58085

Dominik Stadler <do...@gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |PatchAvailable

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org


[Bug 58085] [patch]remove sheet changes sheet reference in formula

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58085

yli <Yu...@ericsson.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 OS|                            |All
            Summary|remove sheet changes sheet  |[patch]remove sheet changes
                   |reference in formula        |sheet reference in formula

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org