You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/04/28 06:48:49 UTC

[GitHub] [echarts] pissang commented on a diff in pull request #16767: feat(sankey): `sankey` support `edgeLabel`

pissang commented on code in PR #16767:
URL: https://github.com/apache/echarts/pull/16767#discussion_r860538464


##########
src/chart/sankey/SankeySeries.ts:
##########
@@ -298,6 +301,12 @@ class SankeySeriesModel extends SeriesModel<SankeySeriesOption> {
             fontSize: 12
         },
 
+        edgeLabel: {
+            show: false,
+            position: 'inside',

Review Comment:
   Should we limit the position to be 'inside' here? I think other position configurations will not fit here since the calculation is based on the bounding box



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org