You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/10/19 21:59:27 UTC

[GitHub] [commons-configuration] garydgregory commented on a diff in pull request #229: CONFIGURATION-822: Fix ambiguity on the section determining

garydgregory commented on code in PR #229:
URL: https://github.com/apache/commons-configuration/pull/229#discussion_r999969785


##########
src/main/java/org/apache/commons/configuration2/INIConfiguration.java:
##########
@@ -349,7 +364,7 @@ public void setCommentLeadingCharsUsedInInput(final String separator) {
      *
      * @param writer - The writer to save the configuration to.
      * @throws ConfigurationException If an error occurs while writing the configuration
-     * @throws IOException if an I/O error occurs.
+     * @throws IOException            if an I/O error occurs.

Review Comment:
   Do not change the formatting please.



##########
src/main/java/org/apache/commons/configuration2/INIConfiguration.java:
##########
@@ -236,12 +236,27 @@ public class INIConfiguration extends BaseHierarchicalConfiguration implements F
      */
     private String commentCharsUsedInInput = COMMENT_CHARS;
 
+    /**
+     * The flag for decision, whether inline comments on the section line are allowed.
+     */
+    private boolean sectionInLineCommentsAllowed;
+
     /**
      * Create a new empty INI Configuration.
      */
     public INIConfiguration() {
     }
 
+    /**
+     * Create a new empty INI Configuration with option to allow inline comments on the section line.
+     *
+     * @param sectionInLineCommentsAllowed when true inline comments on the section line are allowed
+     * @since

Review Comment:
   Version for `since` tags should match `pom.xml` minus `-SNAPSHOT`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org