Re: [PATCH]: mod_cache: don't store headers that will never be used (fwd)

[Niklas Edmundsson <ni...@acc.umu.se>]

I think that this discussion kind of got lost due to vacations or 
something...

In any case, I'd really like to get some closure.

The discussion starts here for those of you that has deleted the 
thread:
http://mail-archives.apache.org/mod_mbox/httpd-dev/200707.mbox/%3cPine.GSO.4.64.0707290942520.6421@kleopatra.acc.umu.se%3e
(the permalink doesn't seem to show the nifty thread list, you have to 
click a bit for that).

What I'd like answered is:
- Was the latest patch as suggested OK?
- What's the correct way of getting the mod_cache configuration from
   the mod_disk_cache module?


/Nikke
-- 
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
  Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se      |     nikke@acc.umu.se
---------------------------------------------------------------------------
  Operator...give me the no for 999, QUICK!
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

---------- Forwarded message ----------
From: Niklas Edmundsson <ni...@acc.umu.se>
To: dev@httpd.apache.org
Date: Wed, 8 Aug 2007 09:28:48 +0200 (MEST)
Subject: Re: [PATCH]: mod_cache: don't store headers that will never be used
Reply-To: dev@httpd.apache.org
X-Bogosity: Unsure, tests=bogofilter, spamicity=0.500000, version=0.96.2

On Tue, 31 Jul 2007, Niklas Edmundsson wrote:

Any opinions on this?

>>>> Here's a version with a config directive, defaults to disabled.
>>> 
>>> Silly Q; a directive?  Or a env var that can be scoped in interesting
>>> ways using mod_setenvif and/or mod_rewrite?
>>> 
>>> Most of our proxy behavior overrides are in terms of envvars.  They are
>>> much more flexible to being tuned per-browser, per-backend etc.
>> 
>> Directive, envvar, I don't think Niklas cares much.  Can we make up our
>> mind please?
> 
> I have no clue on the envvar-stuff, so I don't think I'm qualified to have an 
> opinion. CacheIgnoreCacheControl et al are config directives currently and I 
> have the gut feeling that they should all either be envvar-thingies or config 
> directives, and that starting to mix stuff will only end in confusion and 
> despair ;)
> 
> I prefer a config-option that I can set serverwide without too much fuss 
> since we want this behaviour on all files. If this can also be accomplished 
> with envvar-stuff then sure.
> 
> One way might be to do a config directive for now, and deal with the 
> envvar-stuff separately.
> 
> Related, this config option might also be of interest for mod_disk_cache to 
> enable similar optimizations. What would the "good" way be to accomplish 
> this?
> 
> /Nikke
>


/Nikke
-- 
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
  Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se      |     nikke@acc.umu.se
---------------------------------------------------------------------------
  Now, what was that magic word? Shazam? <WHAM!> Nah - Garibaldi
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Re: [PATCH]: mod_cache: don't store headers that will never be used (fwd)

[Niklas Edmundsson <ni...@acc.umu.se>]

On Wed, 10 Oct 2007, Graham Leggett wrote:

> Niklas Edmundsson wrote:
>
>> What I'd like answered is:
>> - Was the latest patch as suggested OK?
>
> The latest patch was the one with a directive, which is +1 from me - though 
> is it possible to add documentation for the directive?

Sure. Is http://apache-server.com/tutorials/ATdocs-project.html the 
relevant docco-documentation? Should it be a combined patch with both 
code and docs?

>> - What's the correct way of getting the mod_cache configuration from
>>   the mod_disk_cache module?
>
> Look inside mod_proxy_http.c for a function called ap_proxy_read_headers(). 
> In it, the module mod_proxy_http reads the config from the module mod_proxy.

Thanks, I'll take a look :)

/Nikke
-- 
-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
  Niklas Edmundsson, Admin @ {acc,hpc2n}.umu.se      |     nikke@acc.umu.se
---------------------------------------------------------------------------
  Self-made man: A horrible example of unskilled labor.
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Re: [PATCH]: mod_cache: don't store headers that will never be used (fwd)

[Graham Leggett <mi...@sharp.fm>]

Niklas Edmundsson wrote:

> What I'd like answered is:
> - Was the latest patch as suggested OK?

The latest patch was the one with a directive, which is +1 from me - 
though is it possible to add documentation for the directive?

> - What's the correct way of getting the mod_cache configuration from
>   the mod_disk_cache module?

Look inside mod_proxy_http.c for a function called 
ap_proxy_read_headers(). In it, the module mod_proxy_http reads the 
config from the module mod_proxy.

Regards,
Graham
--