You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by "merlimat (via GitHub)" <gi...@apache.org> on 2026/10/23 00:24:56 UTC

Re: [PR] [improve][broker] Use the Producer stats instead of msgOut in geo [pulsar]

merlimat commented on PR #21746:
URL: https://github.com/apache/pulsar/pull/21746#issuecomment-6354362721

   Hi @nodece, thanks for this, and sorry it sat so long. The batching under-count is still there on master (`GeoPersistentReplicator`/`ShadowReplicator` record one event per entry), but I'd rather not turn on client stats for the replication client: it adds a stats recorder per replicator, still counts resends after reconnects, and would leave the `msgOutCounter`/`bytesOutCounter` added in #22972 counting entries. The fix that fits master now is broker-side: record `numMessagesInBatch` for the `Rate` and both counters, ideally from the send callback on success. Since that's a different change on code that has been reworked since, I'm closing this one. A new PR along those lines would be very welcome.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org