You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "wangsheng (Code Review)" <ge...@cloudera.org> on 2020/12/01 07:50:04 UTC
[Impala-ASF-CR] IMPALA-10364: Set the real location for external Iceberg tables stored in HadoopCatalog
wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/16795 )
Change subject: IMPALA-10364: Set the real location for external Iceberg tables stored in HadoopCatalog
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Thanks for this improvement, LGTM
http://gerrit.cloudera.org:8080/#/c/16795/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:
http://gerrit.cloudera.org:8080/#/c/16795/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@2742
PS1, Line 2742: newTable.getSd().setLocation(IcebergUtil.loadTable(
: TIcebergCatalog.HADOOP_CATALOG, identifier,
: IcebergUtil.getIcebergCatalogLocation(newTable)).location());
I think it's better to add comment here to describe the multiple namespaces situation.
--
To view, visit http://gerrit.cloudera.org:8080/16795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I04b75d219e095ce00b4c48f40b8dee872ba57b78
Gerrit-Change-Number: 16795
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Tue, 01 Dec 2020 07:50:04 +0000
Gerrit-HasComments: Yes